Skip the embedded undercover check in Plugin jobs - #92
Closed
apiology wants to merge 3 commits into
Closed
Conversation
The regression, rails, and rspec jobs in plugins.yml run bundle exec rake spec, whose spec task unconditionally shells out to undercover, comparing against origin/master. Their actions/checkout@v3 step used the default shallow, single-ref fetch, so origin/master never existed locally and the undercover subprocess crashed with a Rugged::ReferenceError on every run of these jobs. rspec.yml already fetch-depth: 0 for its own dedicated undercover job, with a comment explaining why. Apply the same setting to the three plugins.yml jobs that hit the same comparison.
rake spec's embedded undercover call compares against origin/master, which does not apply to the regression, rails, and rspec jobs in plugins.yml -- they test solargraph against a plugin combination, not a diff against master. Run rake full_spec instead, which runs the same rspec suite without that comparison. This drops the fetch-depth: 0 checkout change from the previous commit on this branch, which is no longer needed once undercover is not invoked here at all.
The comment on each of the three "Ensure specs still run" steps named what the line used to be rather than what it now does, which reads as a changelog entry. The rake task name already states which suite runs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QRZY46qnEA7iZ9WZJiFae4
apiology
marked this pull request as ready for review
September 9, 2026 16:14
Owner
Author
|
Claude: Moved upstream to castwide#1347. Closing here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was written by Claude Code on behalf of @apiology.
Problem: The
undercovercoverage check crashes on every run of theregression,rails, andrspecjobs inplugins.yml, and nothing surfaces the failure.rake spec's embeddedundercovercall never checks the subprocess's exit status, so these three jobs report green while silently never running a coverage check at all.Solution: Run
rake full_specinstead ofrake specin these three jobs, which runs the same rspec suite without theorigin/mastercomparisonundercoverneeds and these plugin-compatibility jobs do not use.