Point run_solargraph_rspec_specs at the precision-fix branch - #84
Open
apiology wants to merge 1 commit into
Open
Point run_solargraph_rspec_specs at the precision-fix branch#84apiology wants to merge 1 commit into
apiology wants to merge 1 commit into
Conversation
tolerate-hash-literal-inference-versions only tolerates the old and new Hash-literal inference strings. apiology/solargraph-rspec's fix-hash-literal-type-precision branch also tolerates the Array<Integer> precision this PR adds, and backs an open PR against lekemula/solargraph-rspec, so point CI at it instead. apiology/master's plugins.yml never carried the apiology-fork clone or checkout at all (it still cloned lekemula/solargraph-rspec directly) -- this commit introduces the fork pin and the checkout in one step, rather than repointing an existing checkout line.
apiology
marked this pull request as ready for review
September 7, 2026 01:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude:
Problem:
run_solargraph_rspec_specscloneslekemula/solargraph-rspecdirectly with no checkout, so it always runs against that forks default branch. That branchs Hash/Array-literal assertions predate this repos more preciseHash{Symbol => String}/Array<Integer>inference output.Solution: Point the clone at
apiology/solargraph-rspecand check outfix-hash-literal-type-precision, which tolerates the precise inference output and backs an open PR against lekemula/solargraph-rspec (lekemula/solargraph-rspec#36, still open).