Skip to content

Fix Pin::Method#== and Pin::Parameter#type_arity_decl overload bugs #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apiology merged 1 commit into from
Aug 5, 2026
Merged

Fix Pin::Method#== and Pin::Parameter#type_arity_decl overload bugs #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/solargraph/pin/method.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def combine_with other, attrs = {}

# @param other [Pin::Method]
def == other
super && other.node == node
super && other.node == node && other.signatures == signatures
end

def transform_types &transform
Expand Down
2 changes: 1 addition & 1 deletion lib/solargraph/pin/parameter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def arity_decl

# @return [String]
def type_arity_decl
arity_decl + return_type.items.count.to_s
arity_decl + return_type.tags
end

def arg?
Expand Down
Loading