Fix typo and add instance variable test coverage for flow sensitive typing - #20
Merged
Merged
Conversation
Co-authored-by: apiology <3681194+apiology@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ivar support to flow sensitive typing
Fix typo and add instance variable test coverage for flow sensitive typing
Nov 20, 2025
apiology
approved these changes
Nov 22, 2025
apiology
marked this pull request as ready for review
November 22, 2025 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review of the ivar support implementation identified a typo and missing test coverage for the core feature.
Changes
flow_sensitive_typing.rb): "so't provide" → "so provide".is_a?()correctly narrows instance variable types in conditionalsExample
The new test validates this behavior:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.