Union type enforcement base branch - #17

Closed

apiology wants to merge 459 commits into

union_type_enforcement_base

This pull request is big! We're only showing the most recent 250 commits

Commits on Sep 30, 2025

Drop another @sg-ignore
apiology
committed
c35d6a7
Merge remote-tracking branch 'origin/master' into fix_gates_in_arg_types
apiology
committed
73e21c8
Bump for call.rb complexity
apiology
committed
7cba7ca
Merge remote-tracking branch 'origin/master' into method_pin
apiology
committed
053de42
Merge remote-tracking branch 'origin/master' into generic_typechecking_improvements
apiology
committed
2d154ca
Mark spec as now working
apiology
committed
470c26e
Merge remote-tracking branch 'origin/master' into try_again_removing_node_modules_stubs
apiology
committed
523ca94
Merge remote-tracking branch 'origin/master' into stricter_unions
apiology
committed
56a5588
Drop sg-ignores
apiology
committed
06eade6

Commits on Oct 1, 2025

Commits on Oct 5, 2025

Annotation fixes for strong typechecking
apiology
committed
152dbdf
Annotation fixes
apiology
committed
94e650b

Commits on Oct 9, 2025

Merge branch 'handle_more_typechecking_self_situations' into run_strict_typechecking_in_ci
apiology
committed
aa566bc
Merge branch 'overcommit_yardoc_bundle_fix' into run_strict_typechecking_in_ci
apiology
committed
eb1de22
Merge branch 'drop_broken_namespaces_method' into run_strict_typechecking_in_ci
apiology
committed
7bdfa26
Merge branch 'try_again_removing_node_modules_stubs' into run_strict_typechecking_in_ci
apiology
committed
dfe6996
Merge branch 'annotations_2025' into run_strict_typechecking_in_ci
apiology
committed
b2e4954
Add @sg-ignores for issues covered by future PRs
apiology
committed
2240ad7
Add @sg-ignores for issues covered by future PRs
apiology
committed
b0fb367
Add future specs
apiology
committed
1a2a546
Rename method
apiology
committed
6a95643
Add false_presences arguments
apiology
committed
84ac4ed
Generalize some methods for future expansion
apiology
committed
5753e8f

Commits on Oct 10, 2025

Handle simple 'if foo.nil?' cases
apiology
committed
9aea987
Merge branch 'reduce_num_of_buid_jobs' into flow_sensitive_typing_2_0
apiology
committed
1f47ac7

Commits on Oct 11, 2025

Handle 'if foo' in flow-sensitive typing
apiology
committed
82e5bbf
Set up flow-sensitive typing specs, currently passing and pending
apiology
committed
a30c1e6
Remove nilness in 'foo unless foo.nil? || foo'
apiology
committed
c6c96e3
Handle foo if unrelated && foo
apiology
committed
ab404c8
Handle 'break if foo.nil?'
apiology
committed
b20ad1e
Handle 'if foo ... else foo'
apiology
committed
b0a7294
Refactor
apiology
committed
9cba783
Support 'if foo.nil?' when 'foo' has more than one lvar pin
apiology
committed
3e678e1

Commits on Oct 12, 2025

Support 'return if foo.nil?'
apiology
committed
7b7c640
Support 'return foo unless !foo'
apiology
committed
88156b4
Support 'return if foo.nil?'
apiology
committed
5d1e9ae
Support 'foo = nilable || not_nilable'
apiology
committed
0456bd9
Drop 'pending's which are already working
apiology
committed
9c6c1c1
Handle 'foo = nilable_local || non_nilable' scenarios
apiology
committed
10e7306
Handle 'while foo'
apiology
committed
6f5d60a

Commits on Oct 15, 2025

Handle 'foo unless unrelated || repr.nil?
apiology
committed
82183e4

Commits on Oct 22, 2025

Use presence information to improve local variable type probing
apiology
committed
1a4ef78
Fix issues from typechecking in CI
apiology
committed
8a8469e
Fix type issue
apiology
committed
c29deaf
Fix RuboCop issue
apiology
committed
4608872
Deal with issue seen in typechecking
apiology
committed
350b01e

Commits on Oct 23, 2025

Set default on parameter for solargraph-rails compatibility
apiology
committed
6e0fc44
Set default on parameter for solargraph-rails compatibility
apiology
committed
c9abf56
Force build
apiology
committed
39704a0

Commits on Oct 24, 2025

Add missing-but-probably-needed method
apiology
committed
bba54e7
Merge branch 'local_variable_probiing' into union_type_enforcement_base
apiology
committed
7b8f56d

Commits on Oct 25, 2025

Merge branch 'flow_sensitive_typing_2_0' into union_type_enforcement_base
apiology
committed
77e760d
Fix merge issues
apiology
committed
8a0bf22
Fix merge issues
apiology
committed
1cda7ac
Add @sg-ignore
apiology
committed
41e7d49
Merge branch 'handle_more_typechecking_self_situations' into union_type_enforcement_base
apiology
committed
d49c3f1
Fix @sg-ignore issues
apiology
committed
545ca32
Merge branch 'fix_gates_in_arg_types' into union_type_enforcement_base
apiology
committed
e619c0b
Fix merge issue
apiology
committed
64c94b4
Adjust RuboCop todo
apiology
committed
dd1b0c2
Merge branch 'overcommit_yardoc_bundle_fix' into union_type_enforcement_base
apiology
committed
0139b69
Merge branch 'run_strict_typechecking_in_ci' into union_type_enforcement_base
apiology
committed
b495c06
Merge branch 'stricter_unions' into union_type_enforcement_base
apiology
committed
63a2e22
Fix merge issue
apiology
committed
05f1c1e
Fix merge issue
apiology
committed
1d63a0d
Fix merge issue
apiology
committed
36273f4
Swap ivar expectations
apiology
committed
a36cadc
Fix merge issue
apiology
committed
1bae34b
Add probe method
apiology
committed
104f8ab
Fix merge issue
apiology
committed
6151cb7
Fix merge issue
apiology
committed
9e2ba8a
Drop @sg-ignores
apiology
committed
f72e4a0
Add spec for is_a? in a "break unless" statement
apiology
committed
8e0bf1a
Fix merge issue
apiology
committed
5cdedb8
Add missing loose_unions location
apiology
committed
97ffc4b
Move to enforcement at alpha level for now
apiology
committed
60fb1cb
Merge branch 'stricter_unions' into union_type_enforcement_base
apiology
committed
670cede
Fix type issues
apiology
committed
2263c95
Fix solargraph-rspec issues
apiology
committed
47c4720
Merge remote-tracking branch 'lekemula/enable-solargraph-rspec-plugin-specs' into local_variable_probiing
apiology
committed
a998a85
Allow filename to be nil for solargraph-rspec specs
apiology
committed
f51954a
Merge remote-tracking branch 'lekemula/enable-solargraph-rspec-plugin-specs' into flow_sensitive_typing_2_0
apiology
committed
0cfcd63
Add pending flag
apiology
committed
0834ab1
Use appraisal gem while running solargraph-rspec specs
apiology
committed
105a2c4
Use appraisal gem while running solargraph-rspec specs
apiology
committed
d3c0185
Use appraisal gem while running solargraph-rspec specs
apiology
committed
e376dc5
Spec updates
apiology
committed
a3ed92e
Keep typechecking Ruby versions the same
apiology
committed
4baadb5

Commits on Oct 26, 2025

Annotation fixes
apiology
committed
da508cb
Merge branch 'local_variable_probiing' into union_type_enforcement_base
apiology
committed
7ba09ab
Annotation fixes
apiology
committed
6ba6100
Fix issue with &.
apiology
committed
e15c04d
Merge branch 'flow_sensitive_typing_2_0' into union_type_enforcement_base
apiology
committed
1ea7e1e
Fix merge
apiology
committed
c03d238
Drop accidental file add
apiology
committed
cf9a72a
Remove @sg-ignore
apiology
committed
6ff7332
Drop unused file
apiology
committed
08816d8
Merge branch 'flow_sensitive_typing_2_0' into union_type_enforcement_base
apiology
committed
911970d
Ensure nullable? is on both UniqueType and ComplexType
apiology
committed
27cd225
Merge branch 'local_variable_probiing' into union_type_enforcement_base
apiology
committed
57883f6

Commits on Oct 31, 2025

Refactor
apiology
committed
89cd8b9
Fix comment style
apiology
committed
6b2afc9
Update Gemfile.lock in solargraph-rspec
apiology
committed
3d39026
Drop @sg-ignore
apiology
committed
bd075c5
Update Gemfile.lock in solargraph-rspec
apiology
committed
6319630
Update Gemfile.lock in solargraph-rspec
apiology
committed
1b12f8f
Better handling of 'return if'
apiology
committed
8c5c5fb
Better handling of 'case when'
apiology
committed
aff5fbf
Merge branch 'flow_sensitive_typing_2_0' into union_type_enforcement_base
apiology
committed
04c61ff

Commits on Nov 1, 2025

Drop @sg-ignore
apiology
committed
9bc22d4
Support intersection types
apiology
committed
ba66987
Merge branch 'intersection_types' into union_type_enforcement_base
apiology
committed
ec07372
Fix up param type
apiology
committed
e584d33
Fix merge
apiology
committed
077ddd9
Merge branch 'intersection_types' into flow_sensitive_typing_2_0
apiology
committed
5108fa1
Add downcast method, another falsey type
apiology
committed
bfe7f4e
Fix types
apiology
committed
19a81fe
Fix types
apiology
committed
090099b

Commits on Nov 2, 2025

Merge branch 'flow_sensitive_typing_2_0' into union_type_enforcement_base
apiology
committed
89c0b4e
Fix tags
apiology
committed
a2cffcc
Merge branch 'flow_sensitive_typing_2_0' into union_type_enforcement_base
apiology
committed
8e4c28e

Commits on Nov 3, 2025

Don't set binder to avoid trigger solargraph-rspec bug
apiology
committed
b78965b
Merge branch 'local_variable_probiing' into union_type_enforcement_base
apiology
committed
4ef2dc6
Reproduce solargraph-rspec rspec failure
apiology
committed
ed23813
Add set -x to debug
apiology
committed
769041b
Use a Ruby version tested by solargraph-rspec
apiology
committed
a4ad163
Mark item fixed
apiology
committed
e6dcf09
Merge branch 'reduce_num_of_buid_jobs' into local_variable_probiing
apiology
committed
340f11c
Add appraisal workaround
apiology
committed
c5df696
Add resgression spec
apiology
committed
7cefc1c

Commits on Nov 12, 2025

Fix solargraph-rspec specs
apiology
committed
cccd47a
Fix RuboCop issues
apiology
committed
d8ef859
Use dev branch for solargraph-rspec for now
apiology
committed
f7bc624
Fix GHA
apiology
committed
461ab2d
Fix linting issues
apiology
committed
b71a184
Add solargraph update
apiology
committed
9a4b889
Fix appraisal in plugins.yml
apiology
committed
069ce93
Catch Gem::Requirement::BadRequirementError
apiology
committed
fae78ad
Merge branch 'method_pin' into local_variable_probiing
apiology
committed
cb4e7ac
Bump Ruy versioin for solargraph-rspec
apiology
committed
0d877a4
Fix build failure via rubygems update
apiology
committed
f886fed
Bump rspec-rails just as solargraph-rails' GHA does
apiology
committed
331f56b
Fix merge
apiology
committed
7021433
Clarify expectation of instance variable lookup from context, but
apiology
committed
3161f91

Commits on Nov 13, 2025

Remove unneeded changes
apiology
committed
a3fc979

Commits on Nov 14, 2025

Drop Block's binder param
apiology
committed
54b65b8
Drop Method's binder param
apiology
committed
dc5237b
Drop binder
apiology
committed
cdc6de7
Drop binder
apiology
committed
f2db365
Drop closure rebinding
apiology
committed
786375e
Drop reset_generated!
apiology
committed
17b120b
Drop binder
apiology
committed
62a447c
Document logic
apiology
committed
379daf2
Use reset_generated! instead, so future cases are handled
apiology
committed
fc4f00f
Revert refactor
apiology
committed
7be2cd1
Reformat
apiology
committed
401b3e6

Commits on Nov 15, 2025

Fix solargraph-rspec specs
apiology
committed
a7cc436
Try rubygems: latest
apiology
committed
fd463fe
Fix new Ruby 4.x issue
apiology
committed
8bbd6f5
Fix new Ruby 4.x issue
apiology
committed
cd2fd9a
Separate out possible bug reproduction from original purpose of spec
apiology
committed
ce65d5f
Trigger build
apiology
committed
c6dbe4d
Fix new bundler issue
apiology
committed
9d26863
Debug
apiology
committed
87ec9b3
Turn off warning diagnostics in CLI
apiology
committed
6a14bd7
Merge branch 'method_pin' into solargraph_rspec_failure
apiology
committed
5348f70
Debug
apiology
committed
7e7604b
Fix pin merging bug
apiology
committed
91d3cd4
Add @sg-ignore
apiology
committed
652fcd2
Merge branch 'solargraph_rspec_failure' into intersection_types
apiology
committed
74c3ec1
Merge branch 'solargraph_rspec_failure' into union_type_enforcement_base
apiology
committed
b80f846
Merge branch 'solargraph_rspec_failure' into run_strict_typechecking_in_ci
apiology
committed
8359d06

Commits on Nov 16, 2025

Merge branch 'local_variable_probiing' into union_type_enforcement_base
apiology
committed
a066a8b
Add @sg-ignore
apiology
committed
fe06cf3
Pull in solargraph-rspec fixes from another branch
apiology
committed
9b6aa30
Drop @sg-ignores
apiology
committed
19eae82
Add @sg-ignore
apiology
committed
482671b
Merge branch 'annotations_2025' into run_strict_typechecking_in_ci
apiology
committed
82c5680
Merge branch 'solargraph_rspec_failure' into annotations_2025
apiology
committed
1af7057
Drop @sg-ignore
apiology
committed
b1d0b21
Use consistent ruby versions for typechecking
apiology
committed
973b512
Merge branch 'intersection_types' into union_type_enforcement_base
apiology
committed
52894d9
Merge branch 'run_strict_typechecking_in_ci' into union_type_enforcement_base
apiology
committed
5b7c980
Remove @sg-ignores
apiology
committed
390d68a
Add @sg-ignores
apiology
committed
f9114dc
Adjust @sg-ignores
apiology
committed
680638d
Restore @sg-ignores
apiology
committed
6f2e8bb
Fix issue revealed by this PR's change
apiology
committed
4f94ef8
Merge branch 'local_variable_probiing' into union_type_enforcement_base
apiology
committed
35d8cfb
Mark spec as pending
apiology
committed
c7028dc
Mark spec as pending
apiology
committed
0d854cd
Add @sg-ignores
apiology
committed
f8ded08
Drop dead code
apiology
committed
ec29b25
Merge branch 'intersection_types' into union_type_enforcement_base
apiology
committed
8590b21
Use latest rubygems
apiology
committed
4d0366b
Remove unused file
apiology
committed
963c135
Merge branch 'solargraph_rspec_failure' into remove_dead_file
apiology
committed
3e2a67c
Merge branch 'remove_dead_file' into union_type_enforcement_base
apiology
committed
86f3ca2
Merge branch 'solargraph_rspec_failure' into flow_sensitive_typing_2_0
apiology
committed
2df9fb5
Merge branch 'stricter_unions' into or_support_in_flow_sensitive_typing
apiology
committed
5b63c53
Add failing spec
apiology
committed
a12d959
Add implementation
apiology
committed
71f0e74
Merge branch 'or_support_in_flow_sensitive_typing' into union_type_enforcement_base
apiology
committed
a0b3b62
Merge branch 'local_variable_probiing' into or_support_in_flow_sensitive_typing
apiology
committed
7bb3e34
Fix @sg-ignore issues
apiology
committed
a7b7833
Fix solargraph-rails specs issue
apiology
committed
b524eec
Drop workaround
apiology
committed
5e5b6e5
Merge branch 'local_variable_probiing' into or_support_in_flow_sensitive_typing
apiology
committed
72a57a0
Use is_a? in a simple if() with a union to refine types
apiology
committed
1d7106e
Merge branch 'or_support_in_flow_sensitive_typing' into union_type_enforcement_base
apiology
committed
ef9f25e
Fix specs
apiology
committed
2547145
Merge branch 'overcommit_yardoc_bundle_fix' into or_support_in_flow_sensitive_typing
apiology
committed
7a742df
Merge branch 'or_support_in_flow_sensitive_typing' into union_type_enforcement_base
apiology
committed
5c18f4b
Use same ruby version for all typechecking for consistency
apiology
committed
c411211
Rename rule to match future PR
apiology
committed
9c8ed51
Merge branch 'solargraph_rspec_failure' into stricter_unions
apiology
committed
5e03ba9
Merge branch 'stricter_unions' into union_type_enforcement_base
apiology
committed
b5c656d
Fix polarity
apiology
committed
7ea7bfd
Merge branch 'stricter_unions' into union_type_enforcement_base
apiology
committed
c300b4b

Commits on Nov 24, 2025

Commits on Nov 27, 2025

Push logic up to BaseVariable for future expansion
apiology
committed
08626af
Merge branch 'local_variable_probiing' into union_type_enforcement_base
apiology
committed
803974b
Merge fix
apiology
committed
9ec6433
Fix merge
apiology
committed
8e2a094

Commits on Nov 28, 2025

Commits on Nov 29, 2025

Drop @sg-ignores
apiology
committed
5a4aae2
Add missing spec after experiencing subtle merge error
apiology
committed
f74a49d
Merge branch 'or_support_in_flow_sensitive_typing' into union_type_enforcement_base
apiology
committed
b289374
Fix type
apiology
committed
1401373
Merge branch 'annotations_2025' into union_type_enforcement_base
apiology
committed
9bd0ebe
Fix annotations
apiology
committed
d27a522
Handle an issue brought out by future merge
apiology
committed
8701af7
Merge branch 'intersection_types' into union_type_enforcement_base
apiology
committed
f4e2b3e
Fixes based on future branch type checking
apiology
committed
08024bd
Merge branch 'intersection_types' into union_type_enforcement_base
apiology
committed
7fba8bb