tests for: Make resource constructor parameters writables#1991
Closed
komik966 wants to merge 2 commits intoapi-platform:masterfrom
Closed
tests for: Make resource constructor parameters writables#1991komik966 wants to merge 2 commits intoapi-platform:masterfrom
komik966 wants to merge 2 commits intoapi-platform:masterfrom
Conversation
This is motivated because other tools are already constructor friendly (ie Symfony serializer and Doctrine). Also using constructors must be recommended and not supporting them is a serious feature missing.
Contributor
|
we should try get these extra test in, no? |
Member
|
@bendavies yes, why has it be closed? |
Contributor
Author
|
I'll open new PR with tests and fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relations test for #1749