[QNN] Add qnn.rsqrt op#9982
Merged
Merged
Conversation
sfvaroglu
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
mbrookhart
reviewed
Jan 19, 2022
mbrookhart
left a comment
mbrookhart
left a comment
Contributor
There was a problem hiding this comment.
I'd like to see a more concrete comment on the design decision for canonicalizing to fp32 and possible future workarounds, but otherwise, a quick overview looks great!
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
Contributor
There was a problem hiding this comment.
LGTM , but one comment
sfvaroglu
force-pushed
the
sevin/qrsqrt
branch
from
e2c8db6 to
a9333ba
Compare
Contributor
|
Probably just need to rebase on main after 589fc01 The CI failure does not seem to be the fault of the PR |
sfvaroglu
force-pushed
the
sevin/qrsqrt
branch
from
a9333ba to
246ea29
Compare
mbrookhart
approved these changes
Jan 24, 2022
yuanfz98
pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
* Add qnn.rsqrt op * Add comment
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* Add qnn.rsqrt op * Add comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add QNN op for reciprocal sqrt, the default legalization goes through dequantize->rsqrt->quantize