Add bot to ping reviewers after no activity#9973
Merged
Merged
Conversation
driazati
requested review from
a team,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
github-actions
Bot
requested review from
denise-k
and removed request for
a team
denise-k
approved these changes
Jan 21, 2022
denise-k
left a comment
denise-k
left a comment
Contributor
There was a problem hiding this comment.
nice! this is a great feature add.
areusch
reviewed
Jan 27, 2022
areusch
left a comment
areusch
left a comment
Contributor
There was a problem hiding this comment.
thanks @driazati, can you also add some docs in https://tvm.apache.org/docs/contribute/code_review.html?
areusch
approved these changes
Feb 2, 2022
areusch
left a comment
areusch
left a comment
Contributor
There was a problem hiding this comment.
approving so we can try this out. it's scoped to just folks who are cc'd in the attached issue. before we broaden the list of people who will get pinged, we'll raise an RFC to discuss this process change.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* Add bot to ping reviewers after no activity * Address comments Co-authored-by: driazati <driazati@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add a comment from GitHub actions after X amount of time has passed after the last comment on a PR. This should help keep the backlog of PRs clean by remininding people to do a review or update their PRs. Unlike issues where having long term open issues that are legit bugs, PRs shouldn't be open indefinitely, so this bot will incentivize people to keep the PR backlog clean.
The specific rule this operates under is: if there has been no comment or review in
--wait-time-minutes(as checked by GitHub Actions every 15 minutes via the cron workflow in this PR), leave a comment on the PR @-ing all the relevant people, including anyone who has left a review or who was cc'ed at any point in the PR.This is going to start out as opt-in only (with the goal of rolling it out to everyone after like a week or so) just because it's pretty difficult to test. To opt-in, add yourself as a cc'ed user on #9983
cc @areusch @jroesch @denise-k