[CUDNN] Refactor descriptor initialization, remove cudnn.conv.output_shape_from_cudnn#9948
Merged
Conversation
masahi
requested review from
ZihengJiang,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
kazum,
liangfu,
merrymercy,
tmoreau89,
tqchen,
vinx13,
yzhliu and
zhiics
as code owners
Laurawly
approved these changes
Jan 18, 2022
yuanfz98
pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
…_shape_from_cudnn` (apache#9948) * Introduce SetConvdescriptors to refactor cudnn/conv_forward.cc * more refactor * remove cudnn get output * cpplint
crazydemo
pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
…_shape_from_cudnn` (apache#9948) * Introduce SetConvdescriptors to refactor cudnn/conv_forward.cc * more refactor * remove cudnn get output * cpplint
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
…_shape_from_cudnn` (apache#9948) * Introduce SetConvdescriptors to refactor cudnn/conv_forward.cc * more refactor * remove cudnn get output * cpplint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for adding cudnn gradient kernels, I wanted to refactor the duplicated logic of various descriptor initialization.
Also removes
tvm.contrib.cudnn.conv.output_shape_from_cudnnsince it is no longer used.@Hzfengsy @comaniac @Laurawly