Skip to content

[TIR] Canonical simplify the intset before region cover proof #9941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hzfengsy merged 3 commits into from
Feb 8, 2022
Merged

[TIR] Canonical simplify the intset before region cover proof #9941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f229662
canonical simplify the intset before region cover proof
wrongtest-intellif Jan 15, 2022
f076822
add more rewrite rule for intimms to fix the issue after rebase
wrongtest-intellif Jan 16, 2022
2fca571
remove rewrite rules, there are existing rule can work after canonica…
wrongtest-intellif Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/tir/schedule/state.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,16 @@ bool ProducerCoversConsumer(const Array<PrimExpr>& buffer_shape,
if (produced_region[i].IsNothing()) {
return false;
}
arith::IntSet produced = arith::Intersect({produced_region[i], buffer_size});
arith::IntSet consumed = arith::Intersect({consumed_region[i], buffer_size});
PrimExpr produced_min = analyzer->Simplify(produced.min());
PrimExpr produced_max = analyzer->Simplify(produced.max());
PrimExpr consumed_min = analyzer->Simplify(consumed.min());
PrimExpr consumed_max = analyzer->Simplify(consumed.max());
if (!analyzer->CanProve((produced_min <= consumed_min) && (consumed_max <= produced_max))) {
arith::IntSet produced =
arith::IntSet::Interval(analyzer->canonical_simplify(produced_region[i].min()),
analyzer->canonical_simplify(produced_region[i].max()));
arith::IntSet consumed =
arith::IntSet::Interval(analyzer->canonical_simplify(consumed_region[i].min()),
analyzer->canonical_simplify(consumed_region[i].max()));
produced = arith::Intersect({produced, buffer_size});
consumed = arith::Intersect({consumed, buffer_size});
if (!analyzer->CanProve((analyzer->canonical_simplify(produced.min() - consumed.min()) <= 0) &&
(analyzer->canonical_simplify(consumed.max() - produced.max()) <= 0))) {
return false;
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/python/unittest/test_tir_schedule_state_cached_flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ def test_non_perfect_tiling_cache():
)
assert s._get_cached_flags(_get_block(s, "compute")) == CachedFlags(
affine_binding=True,
region_cover=False,
region_cover=True,
stage_pipeline=True,
)
# pylint: enable=protected-access
Expand Down