Add contribute page about CI#9906
Merged
Merged
Conversation
electriclilies
left a comment
electriclilies
left a comment
Contributor
There was a problem hiding this comment.
This is awesome, thanks! I think adding a few details about building TVM once you're in the docker container would be helpful (left details inline). Looking forward to this going in!
driazati
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
leandron
reviewed
Jan 14, 2022
| ************* | ||
|
|
||
| .. |top_of_the_Jenkinsfile| replace:: top of the ``Jenkinsfile`` | ||
| .. _top_of_the_Jenkinsfile: https://github.com/apache/tvm/blob/7481a297740f073b193a3f09b3e27f056e8c7f2e/Jenkinsfile#L48-L54 |
Contributor
There was a problem hiding this comment.
I think it would be simpler here to reproduce a snippet of the Jenkins file, rather than link to a specific git hash.
Member
Author
There was a problem hiding this comment.
I didn't want to run the risk of this being out of date with no context, if the Jenkinsfile changes at some point this way there is at least an obvious trail (i.e. the linked commit is too old) rather than a code snippet which is much harder to track down and see when/why it changed
areusch
pushed a commit
to tlc-pack/web-data
that referenced
this pull request
Jan 14, 2022
Co-authored-by: driazati <driazati@users.noreply.github.com>
This adds some docs with a description of the TVM CI and some usage instructions to both make contributing more friendly and educate existing developers about how CI runs. Bikeshedding on content is welcome Note: The TODOs are blocked on some other PRs and will be done before landing
Member
|
Thanks for the feedback everyone, feel free to send a PR or message David for further follow up work. |
jroesch
approved these changes
Jan 19, 2022
Merged
yuanfz98
pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
* Add contribute page about CI This adds some docs with a description of the TVM CI and some usage instructions to both make contributing more friendly and educate existing developers about how CI runs. Bikeshedding on content is welcome Note: The TODOs are blocked on some other PRs and will be done before landing * docker instructions * Comments * Rebase Co-authored-by: driazati <driazati@users.noreply.github.com>
crazydemo
pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
* Add contribute page about CI This adds some docs with a description of the TVM CI and some usage instructions to both make contributing more friendly and educate existing developers about how CI runs. Bikeshedding on content is welcome Note: The TODOs are blocked on some other PRs and will be done before landing * docker instructions * Comments * Rebase Co-authored-by: driazati <driazati@users.noreply.github.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* Add contribute page about CI This adds some docs with a description of the TVM CI and some usage instructions to both make contributing more friendly and educate existing developers about how CI runs. Bikeshedding on content is welcome Note: The TODOs are blocked on some other PRs and will be done before landing * docker instructions * Comments * Rebase Co-authored-by: driazati <driazati@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some docs with a description of the TVM CI and some usage instructions to both make contributing more friendly and educate existing developers about how CI runs. Bikeshedding on content is welcome
cc @areusch @konturn