Skip to content

[MetaSchedule][M4b] Misc improvement of the Measurer#9757

Merged
junrushao merged 3 commits into
apache:mainfrom
sunggg:builder-runner-misc
Dec 18, 2021
Merged

[MetaSchedule][M4b] Misc improvement of the Measurer#9757
junrushao merged 3 commits into
apache:mainfrom
sunggg:builder-runner-misc

Conversation

@sunggg

@sunggg sunggg commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

Nice to meet you all.

This PR contains several changes in meta_scheudle runner and builder.
Please review this and feel free to give any feedback.

Thank you!

@junrushao junrushao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! @sunggg let's fix the CI :-)

Comment thread python/tvm/meta_schedule/builder/local_builder.py Outdated
Comment thread python/tvm/meta_schedule/runner/local_runner.py Outdated
Comment thread python/tvm/meta_schedule/runner/rpc_runner.py Outdated
@junrushao

Copy link
Copy Markdown
Member

CC: @Hzfengsy @yidawang

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao junrushao changed the title [MetaScheduler] Misc improvement of the Measurer [MetaSchedule] Misc improvement of the Measurer Dec 16, 2021
@junrushao

Copy link
Copy Markdown
Member

Hey you forgot the fix the two "ditto"s :-)

@Hzfengsy Hzfengsy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunggg

sunggg commented Dec 17, 2021

Copy link
Copy Markdown
Contributor Author

@junrushao1994, Aren't there three files in total?
My new commit contains changes in three files you mentioned.

I'm now seeing this message.

Some checks were not successful
2 successful and 1 errored checks

Since I'm new to this system, any advice would be greatly appreciated!

@junrushao

Copy link
Copy Markdown
Member

Oh I’m sorry that I misread! The linter error this time is that we forgot to add docs for “params” in c++

@junrushao

Copy link
Copy Markdown
Member

CC @zxybazh for review

@zxybazh zxybazh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @sunggg !

@junrushao junrushao merged commit 115919b into apache:main Dec 18, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
@junrushao junrushao changed the title [MetaSchedule] Misc improvement of the Measurer [MetaSchedule][M4b] Misc improvement of the Measurer Jan 26, 2022
qsqqsqqsq-intellif pushed a commit to qsqqsqqsq-intellif/tvm that referenced this pull request Apr 29, 2022
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants