[microNPU] Support different constant datatypes#9626
Merged
Conversation
lhutton1
force-pushed
the
different-constant-data-types
branch
from
7d6e8ef to
d49e9e1
Compare
lhutton1
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
ekalda
reviewed
Dec 2, 2021
ekalda
left a comment
ekalda
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Just some comments from the 'enlightenment' category
lhutton1
commented
Dec 2, 2021
lhutton1
force-pushed
the
different-constant-data-types
branch
from
d49e9e1 to
130ce9c
Compare
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant. Change-Id: I99e34fe17905b1bb7d916e346cebfc324e3a2a0c
Change-Id: I8432f3d9dcc1001bbad40b76127075a1019197d4
Change-Id: I9b8b9df3af27023f60ef4934a918d40140a9534f
lhutton1
force-pushed
the
different-constant-data-types
branch
from
130ce9c to
d785a16
Compare
NicolaLancellotti
approved these changes
Dec 6, 2021
Contributor
|
This is merged! Thanks @ekalda @lhutton1 @NicolaLancellotti. |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph. A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only uint8 datatype is supported for constants, as this is all that was necessary until now. This PR allows different datatypes to be used for constants, including different datatypes within the same graph.
A workaround was previously added for Mean legalization, this has also been removed and replaced with the expected datatype of the constant.
Note: this PR is dependent on #9576 so contains the contents of that PR also.cc @manupa-arm @ekalda @mbaret @NicolaLancellotti @dchauhan-arm