[BugFix][Micro] fix tvm.micro ImportError in tvmc when USE_MICRO is OFF#9619
[BugFix][Micro] fix tvm.micro ImportError in tvmc when USE_MICRO is OFF#9619ZQPei wants to merge 1 commit into
Conversation
d31fa50 to
99f4c72
Compare
Signed-off-by: ZQPei <ziqiangpei@foxmail.com>
99f4c72 to
f30f557
Compare
|
@ZQPei oh pardon, even with @leandron tagging me I missed that PR. Thanks for reporting and proposing a fix. Since I was not aware of yours I created earlier today #9632 I'm wondering if you could kindly test it too and check if it also fixes your issue. My take is that |
Yeah, looks good to me. It can also fix the issue and is more concise. |
@ZQPei 👍 Thanks for the review and for checking that it fixes your issue too. |
|
@ZQPei if you're happy with the other PR, shall we close this PR and move forward with the other? |
Yes, of course |
As discussed in issue #9617.
Recently
tvm.microis imported by tvmc even thoughUSE_MICROmacro isOFF.This bug was mistakenly introduced by #9229.
As we can see in
tvm/python/tvm/driver/tvmc/__init__.py
Line 22 in 32e8012
and
tvm/python/tvm/driver/tvmc/runner.py
Lines 37 to 39 in 32e8012
I tried to fix it by,
check_micro_supportapi totvm.support,tvm.microaftercheck_micro_supportto preserve tvm with USE_MICRO OFF.