Add the Arm(R) Ethos(TM)-U NPU identity operator#9457
Merged
Conversation
ekalda
commented
Nov 5, 2021
ekalda
commented
Contributor
- Add the ethosu.identity operator which returns the input tensor
- Add an opportunity to requantize the tensor
- Add legalization for reshape and strided slice
- Add a pass that puts an indentity op after a no-op
ekalda
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
November 5, 2021 11:00
Contributor
Author
mbaret
reviewed
Nov 5, 2021
| def transform_module( | ||
| self, mod: tvm.ir.IRModule, ctx: tvm.ir.transform.PassContext | ||
| ) -> tvm.ir.IRModule: | ||
| """Legalize the oerators that can be offloaded to the NPU""" |
Contributor
Author
There was a problem hiding this comment.
A different docstring appeared in the rebase, so I kept that that different docstring
| qnn_avgpool2d_pattern(), | ||
| lambda pat: AvgPool2DParams(pat).is_valid(), | ||
| ), | ||
| ("ethosu.strided_slice", strided_slice_pattern(), lambda pat: True), |
Contributor
There was a problem hiding this comment.
Let's put the proper restrictions here so we don't accidentally offload, for example, floating point tensors.
| Parameters | ||
| ---------- | ||
| stmt : tvm.tir.AttrStmt | ||
| The outermost attribute statement of a convolution loop nest. |
| .describe(R"code(Identity operator for Ethos-U NPUs. | ||
|
|
||
| This Relay operator performs the identity operation on Ethos(TM)-U NPU with a capability | ||
| to requantize the data. It accepts input with any shape that is less or equal to 4. |
Contributor
There was a problem hiding this comment.
Maybe 'It accepts input tensors of 4 dimensions or less.'?
|
|
||
|
|
||
| @pytest.mark.parametrize("accel_type", ACCEL_TYPES) | ||
| @pytest.mark.parametrize( |
Contributor
There was a problem hiding this comment.
We should either test the 'special' indices for reshape (-1 and -2), or we should explicitly disallow these.
| ], | ||
| ) | ||
| def test_relay_reshape_codegen(ifm_shape, new_shape, accel_type): | ||
| # Create a "partitioned" Relay graph |
Contributor
There was a problem hiding this comment.
It seems like some of this could be refactored out into a common function and reused between tests.
| run_opt_pass(func, relay.transform.InferType()) | ||
|
|
||
|
|
||
| def test_ethosu_invalid_invalid_dtype(): |
Contributor
There was a problem hiding this comment.
test_ethosu_identity_invalid_dtype
| run_opt_pass(func, relay.transform.InferType()) | ||
|
|
||
|
|
||
| def test_ethosu_identity_invalid_shape(): |
Contributor
There was a problem hiding this comment.
I think we need to test the valid cases as well.
15 tasks
lhutton1
reviewed
Nov 8, 2021
* Add the ethosu.identity operator which returns the input tensor * Add an opportunity to requantize the tensor * Add legalization for reshape and strided slice * Add a pass that puts an indentity op after a no-op Change-Id: I0adb5ca269f8529c79e0e7681ca4b5147d8f53c8
Change-Id: Icc9b6507f164681a5d6b1fcff2ae4a5051d44734
Change-Id: I63f30f84ad481789fc047ad8c2107f5313562f7f
ekalda
force-pushed
the
identity_upstream
branch
from
November 16, 2021 10:12
75d1117 to
ac87b0b
Compare
Contributor
Author
|
@mbaret @NicolaLancellotti @lhutton1 thanks for the reviews, much appreciated! :) |
lhutton1
approved these changes
Nov 16, 2021
Contributor
|
Thanks everyone, this is now merged! |
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* Add the Arm(R) Ethos(TM)-U NPU identity operator * Add the ethosu.identity operator which returns the input tensor * Add an opportunity to requantize the tensor * Add legalization for reshape and strided slice * Add a pass that puts an indentity op after a no-op Change-Id: I0adb5ca269f8529c79e0e7681ca4b5147d8f53c8 * Fix the pylint errors Change-Id: Icc9b6507f164681a5d6b1fcff2ae4a5051d44734 * Changes in response to review comments Change-Id: I63f30f84ad481789fc047ad8c2107f5313562f7f
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
* Add the Arm(R) Ethos(TM)-U NPU identity operator * Add the ethosu.identity operator which returns the input tensor * Add an opportunity to requantize the tensor * Add legalization for reshape and strided slice * Add a pass that puts an indentity op after a no-op Change-Id: I0adb5ca269f8529c79e0e7681ca4b5147d8f53c8 * Fix the pylint errors Change-Id: Icc9b6507f164681a5d6b1fcff2ae4a5051d44734 * Changes in response to review comments Change-Id: I63f30f84ad481789fc047ad8c2107f5313562f7f
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* Add the Arm(R) Ethos(TM)-U NPU identity operator * Add the ethosu.identity operator which returns the input tensor * Add an opportunity to requantize the tensor * Add legalization for reshape and strided slice * Add a pass that puts an indentity op after a no-op Change-Id: I0adb5ca269f8529c79e0e7681ca4b5147d8f53c8 * Fix the pylint errors Change-Id: Icc9b6507f164681a5d6b1fcff2ae4a5051d44734 * Changes in response to review comments Change-Id: I63f30f84ad481789fc047ad8c2107f5313562f7f
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
* Add the Arm(R) Ethos(TM)-U NPU identity operator * Add the ethosu.identity operator which returns the input tensor * Add an opportunity to requantize the tensor * Add legalization for reshape and strided slice * Add a pass that puts an indentity op after a no-op Change-Id: I0adb5ca269f8529c79e0e7681ca4b5147d8f53c8 * Fix the pylint errors Change-Id: Icc9b6507f164681a5d6b1fcff2ae4a5051d44734 * Changes in response to review comments Change-Id: I63f30f84ad481789fc047ad8c2107f5313562f7f
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Add the Arm(R) Ethos(TM)-U NPU identity operator * Add the ethosu.identity operator which returns the input tensor * Add an opportunity to requantize the tensor * Add legalization for reshape and strided slice * Add a pass that puts an indentity op after a no-op Change-Id: I0adb5ca269f8529c79e0e7681ca4b5147d8f53c8 * Fix the pylint errors Change-Id: Icc9b6507f164681a5d6b1fcff2ae4a5051d44734 * Changes in response to review comments Change-Id: I63f30f84ad481789fc047ad8c2107f5313562f7f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.