[microTVM][Arduino] Cleanup template directory#9289
Merged
Conversation
Member
Author
Contributor
Contributor
|
@mehrdadh BTW, I found out that the following fixes are needed in Arduino while reviewing your changes, but naturally your changes are independent. I'll submit them later today: Author: Gustavo Romero <gustavo.romero@linaro.org>
Date: Mon Oct 18 21:25:26 2021 +0000
Fix Arduino
diff --git a/apps/microtvm/arduino/template_project/microtvm_api_server.py b/apps/microtvm/arduino/template_project/microtvm_api_server.py
index 3d25d0bca..85263137f 100644
--- a/apps/microtvm/arduino/template_project/microtvm_api_server.py
+++ b/apps/microtvm/arduino/template_project/microtvm_api_server.py
@@ -152,7 +152,9 @@ class Handler(server.ProjectAPIHandler):
return server.ServerInfo(
platform_name="arduino",
is_template=IS_TEMPLATE,
- model_library_format_path=MODEL_LIBRARY_FORMAT_PATH,
+ model_library_format_path=""
+ if IS_TEMPLATE
+ else MODEL_LIBRARY_FORMAT_PATH,
project_options=PROJECT_OPTIONS,
)
@@ -352,7 +354,7 @@ class Handler(server.ProjectAPIHandler):
# Unpack the MLF and copy the relevant files
metadata = self._disassemble_mlf(model_library_format_path, source_dir)
- shutil.copy2(model_library_format_path, source_dir / "model")
+ shutil.copy2(model_library_format_path, project_dir / MODEL_LIBRARY_FORMAT_RELPATH)
# For AOT, template model.h with metadata to minimize space usage
if options["project_type"] == "example_project": |
Member
Author
|
@gromero thanks for the review! PTAL. |
gromero
approved these changes
Oct 18, 2021
areusch
approved these changes
Oct 21, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* restructure * readme * fix readme * trigger
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* restructure * readme * fix readme * trigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restructures the template project for Arduino as part of adding Arduino to TVM package efforts.