[Script][TensorIR] update block syntax#9286
Merged
Merged
Conversation
Hzfengsy
requested review from
ZihengJiang,
areusch,
comaniac,
jroesch,
junrushao,
kparzysz-quic,
leandron,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu and
zhiics
as code owners
Member
|
Thanks @Hzfengsy! It's a painstaking refactor and finally you made it! |
shingjan
reviewed
Oct 14, 2021
shingjan
left a comment
shingjan
left a comment
There was a problem hiding this comment.
Thanks for this huge effort! Is there a RFC or thread that one can follow to see the significance of this refactor?
Hzfengsy
force-pushed
the
block_syntax
branch
3 times, most recently
from
2ac3e54 to
245966d
Compare
Hzfengsy
force-pushed
the
block_syntax
branch
from
245966d to
d3569dc
Compare
Member
|
Let's get it merged on Monday just to avoid weekend merge. |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for updating block syntax. Please see RFC: here
cc @junrushao1994 @tqchen @tkonolige