Skip to content

[Relay][UnitTest] Removed redundant unit test.#8993

Merged
masahi merged 1 commit into
apache:mainfrom
Lunderberg:test_conv2d_relay
Sep 13, 2021
Merged

[Relay][UnitTest] Removed redundant unit test.#8993
masahi merged 1 commit into
apache:mainfrom
Lunderberg:test_conv2d_relay

Conversation

@Lunderberg

Copy link
Copy Markdown
Contributor

test_op_level2.py::test_conv2d should have been removed in the refactoring in #8947. All functionality tested by it is in test_op_level2.py::TestConv2D.

@masahi

masahi commented Sep 13, 2021

Copy link
Copy Markdown
Member

What about

class TestAnyReduce:

and

def test_any_reduce():

?

@Lunderberg

Copy link
Copy Markdown
Contributor Author

That one should also be removed, and I will update the PR. Looks like I didn't find it in my initial search because pytest --collect-only can print in the order of parametrization, not necessarily in file-by-file order. I wrote a quick script to check the output of pytest --collect-only instead of looking over it by hand, and test_any_reduce is the last one in tests/python/relay with this accidental repetition.

test_op_level2.py::test_conv2d and test_any.py::test_any_reduce should
have been removed in the refactoring in apache#8947.  All functionality
tested by it is in test_op_level2.py::TestConv2D and
test_any::TestAnyReduce.
@masahi masahi merged commit 58b9a32 into apache:main Sep 13, 2021
@Lunderberg Lunderberg deleted the test_conv2d_relay branch September 13, 2021 21:20
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
test_op_level2.py::test_conv2d and test_any.py::test_any_reduce should
have been removed in the refactoring in apache#8947.  All functionality
tested by it is in test_op_level2.py::TestConv2D and
test_any::TestAnyReduce.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
test_op_level2.py::test_conv2d and test_any.py::test_any_reduce should
have been removed in the refactoring in apache#8947.  All functionality
tested by it is in test_op_level2.py::TestConv2D and
test_any::TestAnyReduce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants