[Relay to onnx conversion fixes][Pool, Pad]#8435
Conversation
* added missing ceil_mode in average pool and max pool conversion
* Fixed issue in Pad conversion: changed pad_value to input instead of attrs * Refer to PR: #7860 * Updated unit test for Pad * Fixed some formatting errors
trevor-m
left a comment
trevor-m
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @schilkunda-amba
u99127
left a comment
u99127
left a comment
There was a problem hiding this comment.
Thank you for separating out bug fixes from the new features from
I asked in #8362 to please fix the commit message to reflect that these are changes to the ONNX frontend. Relay isn't being converted to ONNX. Its a model in the ONNX format which is being lowered to Relay.
Can the commit message please be updated along with the subject line and summary line of your pull request(s) ? TIA.
regards
Ramana
|
@u99127 I should have probably clarified in the previous PR. The PR is indeed for converting relay to onnx (not the other way round). It's not part of the frontend lowering of onnx to relay. Our compiler expects an onnx model as input (not relay). Hence, with the help of community, we implemented a relay to onnx convertor. Model in any framework -> Relay -> Onnx -> Compiler Hope this clarifies! |
Oh, I'm sorry I missed this . Is there an RFC or something I can read about this new feature ? Ramana Thanks, |
* [Relay to Onnx conversion][Pool] * added missing ceil_mode in average pool and max pool conversion * [Relay to Onnx conversion][Pad] * Fixed issue in Pad conversion: changed pad_value to input instead of attrs * Refer to PR: apache#7860 * Updated unit test for Pad * Fixed some formatting errors
* [Relay to Onnx conversion][Pool] * added missing ceil_mode in average pool and max pool conversion * [Relay to Onnx conversion][Pad] * Fixed issue in Pad conversion: changed pad_value to input instead of attrs * Refer to PR: apache#7860 * Updated unit test for Pad * Fixed some formatting errors
4 participants
Fixed issues in relay to onnx conversion of pool and pad ops.
Pool: Added missing ceil_mode in average pool and max pool conversion
Pad: Changed pad_value to input instead of attrs (#7860)
Updated unit tests and fixed formatting errors.