[FIX] Correct initial data copy of scatter_nd#8419
Closed
tkonolige wants to merge 2 commits into
Closed
Conversation
The initial data copy from `data` to `out` in scatter_nd had too large bounds.
Contributor
|
This is failing the test? I'm not sure this change is correct? |
mbrookhart
approved these changes
Jul 8, 2021
|
Do we not need a new test for this ? And if it fixes the relevant issue, it would be good to mention that in the commit message and link to it ? |
Contributor
|
This PR is duplicated with #8415, you can see a more detailed analysis & explanation of the issue there @mbrookhart @u99127 @tkonolige I've already integrated your change in my fix, so I think it's OK to close this PR now, thank you! |
Contributor
Author
|
Closing in favor of #8415 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial data copy from
datatooutin scatter_nd had too large bounds.@masahi @mbrookhart