Skip to content

[Relay][Parser] Support slash in identifier.#8352

Merged
leandron merged 3 commits into
apache:mainfrom
zackcquic:parser
Jun 29, 2021
Merged

[Relay][Parser] Support slash in identifier.#8352
leandron merged 3 commits into
apache:mainfrom
zackcquic:parser

Conversation

@zackcquic

Copy link
Copy Markdown
Contributor

Variables from tensorflow may contains '/' in name (x/y/z).

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@tqchen @jroesch please help to review this change, which found in tensorflow model

Thanks a lot :)

Regards,
Zack

zackcquic and others added 2 commits June 26, 2021 20:35
Variables from tensorflow may contains '/' in name (x/y/z).
@zackcquic

Copy link
Copy Markdown
Contributor Author

cc @areusch @tkonolige @comaniac
Thanks a lot.

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

Comment thread tests/python/relay/test_ir_text_printer.py

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandron leandron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandron leandron merged commit 4b5c257 into apache:main Jun 29, 2021
@zackcquic zackcquic deleted the parser branch July 5, 2021 01:18
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* [Relay][Parser] Support slash in identifier.

Variables from tensorflow may contains '/' in name (x/y/z).

* Check identifier name after parsing.
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
* [Relay][Parser] Support slash in identifier.

Variables from tensorflow may contains '/' in name (x/y/z).

* Check identifier name after parsing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants