Skip to content

[TOPI][batch_matmul] Allow cblas batch_matmul implicit batch_size broadcast#8250

Merged
masahi merged 2 commits into
apache:mainfrom
ymwangg:batch_matmul
Jun 12, 2021
Merged

[TOPI][batch_matmul] Allow cblas batch_matmul implicit batch_size broadcast#8250
masahi merged 2 commits into
apache:mainfrom
ymwangg:batch_matmul

Conversation

@ymwangg

@ymwangg ymwangg commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

This PR enables implicit batch_size broadcast in topi.x86.batch_matmul. This is useful for some NLP models.

Comment thread python/tvm/topi/x86/batch_matmul.py
Comment thread tests/python/contrib/test_cblas.py Outdated

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masahi masahi merged commit ab16685 into apache:main Jun 12, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
…adcast (apache#8250)

* Allow cblas batch_matmul implicit bcast

* Add cblas batch_matmul bcast when batch_a=1
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
…adcast (apache#8250)

* Allow cblas batch_matmul implicit bcast

* Add cblas batch_matmul bcast when batch_a=1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants