Skip to content

Add metadata information to the PassContext configuration listing function#8226

Merged
jcf94 merged 1 commit into
apache:mainfrom
leandron:pass_context_configs_metadata
Jun 10, 2021
Merged

Add metadata information to the PassContext configuration listing function#8226
jcf94 merged 1 commit into
apache:mainfrom
leandron:pass_context_configs_metadata

Conversation

@leandron

@leandron leandron commented Jun 9, 2021

Copy link
Copy Markdown
Contributor

Add metadata information to the listing of PassContext configuration listing function.

  • Rename PassContext::ListConfigNames() to PassContext::ListConfigs() and its
    Python counterpart tvm.ir.transform.PassContext.list_config_names -> list_configs()
  • Adjust PassContext::ListConfigs() to include also metadata (currently only including the data type)
  • Adjust unit tests

This is a follow up on #8212, and is needed so that I can present better error messages and parsing from the command line.

cc @comaniac @manupa-arm @gromero for reviews

@leandron leandron changed the title Add metadata information to the listing of PassContext configuration listing function Add metadata information to the PassContext configuration listing function Jun 9, 2021

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…listing function

 * Rename PassContext::ListConfigNames() to PassContext::ListConfigs() and its
   Python counterpart tvm.ir.transform.PassContext.list_config_names -> list_configs()

 * Adjust PassContext::ListConfigs() to include also metadata (currently only including the data type)

 * Adjust unit tests
@jcf94 jcf94 merged commit a468f08 into apache:main Jun 10, 2021
@jcf94

jcf94 commented Jun 10, 2021

Copy link
Copy Markdown
Member

Thanks! @leandron @comaniac

@leandron leandron deleted the pass_context_configs_metadata branch June 14, 2021 16:01
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
…listing function (apache#8226)

* Rename PassContext::ListConfigNames() to PassContext::ListConfigs() and its
   Python counterpart tvm.ir.transform.PassContext.list_config_names -> list_configs()

 * Adjust PassContext::ListConfigs() to include also metadata (currently only including the data type)

 * Adjust unit tests
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
…listing function (apache#8226)

* Rename PassContext::ListConfigNames() to PassContext::ListConfigs() and its
   Python counterpart tvm.ir.transform.PassContext.list_config_names -> list_configs()

 * Adjust PassContext::ListConfigs() to include also metadata (currently only including the data type)

 * Adjust unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants