Skip to content

[TensorIR][M2a] Compute-Inline,Reverse-Compute-Inline#8170

Merged
junrushao merged 1 commit into
apache:mainfrom
junrushao:feature/2021-06-01/compute-inline
Jun 4, 2021
Merged

[TensorIR][M2a] Compute-Inline,Reverse-Compute-Inline#8170
junrushao merged 1 commit into
apache:mainfrom
junrushao:feature/2021-06-01/compute-inline

Conversation

@junrushao

Copy link
Copy Markdown
Member

This PR is part of the TensorIR upstreaming effort (#7527), which adds the first 2 schedule primitives:

  • compute-Inline
  • reverse-compute-inline

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly nits.

Comment thread src/support/array.h Outdated
Comment thread src/tir/schedule/analysis.h
Comment thread src/tir/schedule/utils.h Outdated
This PR is part of the TensorIR upstreaming effort (#7527), which adds the first 2 schedule primitives:

- compute-Inline
- reverse-compute-inline

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
@junrushao junrushao requested review from comaniac, jcf94 and tqchen June 3, 2021 20:55
@junrushao

Copy link
Copy Markdown
Member Author

Hey sorry for the late response! I addressed the comments accordingly. Please take another look :-)

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcf94 jcf94 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@junrushao junrushao merged commit dd09bbb into apache:main Jun 4, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
This PR is part of the TensorIR upstreaming effort (apache#7527), which adds the first 2 schedule primitives:

- compute-Inline
- reverse-compute-inline

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
This PR is part of the TensorIR upstreaming effort (apache#7527), which adds the first 2 schedule primitives:

- compute-Inline
- reverse-compute-inline

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants