[Target] Add a default warp size 1 for vulkan and opencl#8109
Merged
Conversation
Member
|
The code looks good to me. May I know why the default |
Member
Author
|
Because it need to support ALL vulkan or opencl devices. 1 is the only value that could work, but it is useless in terms of performance. It's only there so that compiling models on vulkan wouldn't break. |
Member
|
Thanks for the quick reply. In that case, |
Contributor
|
Looks good to me, and I agree on using 1 as the default |
tqchen
approved these changes
May 22, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made this change too many times during my development, to workaround topi
scatterop that requiresthread_warp_sizefor no good reason. Since #8030transposeop also requiresthread_warp_sizeand all models that use transpose op are broken on vk.@tmoreau89 @Lunderberg @junrushao1994 @zxybazh