Skip to content

Quantized TANH operator support in TF Lite Frontend#8024

Merged
mbaret merged 1 commit into
apache:mainfrom
NicolaLancellotti:TFLite/TANH
May 20, 2021
Merged

Quantized TANH operator support in TF Lite Frontend#8024
mbaret merged 1 commit into
apache:mainfrom
NicolaLancellotti:TFLite/TANH

Conversation

@NicolaLancellotti

Copy link
Copy Markdown
Contributor

Currently, the TANH operator with quantized input and output tensors is lowered to
tanh without any prior dequantization and posterior quantization.
This pr adds the dequantization and quantization operators to the lowering of TANH.

@NicolaLancellotti

Copy link
Copy Markdown
Contributor Author

Please, can you review? @mbaret @manupa-arm

@manupak manupak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-smirnov d-smirnov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legitimate

Comment thread tests/python/frontend/tflite/test_forward.py
@mbaret

mbaret commented May 19, 2021

Copy link
Copy Markdown
Contributor

Could you re-trigger the CI? It's been very flaky lately.

Change-Id: I70df765e1562fa586ed0ffd0e07b8858f7fbb831
@mbaret mbaret merged commit ec3b160 into apache:main May 20, 2021
@mbaret

mbaret commented May 20, 2021

Copy link
Copy Markdown
Contributor

Thanks @NicolaLancellotti @manupa-arm @d-smirnov this is now merged.

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
@NicolaLancellotti NicolaLancellotti deleted the TFLite/TANH branch May 25, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants