[BYOC] Remove ext params stored in metadata from params to avoid duplication#7977
Merged
Conversation
Contributor
Author
comaniac
reviewed
May 5, 2021
comaniac
left a comment
Contributor
There was a problem hiding this comment.
The change looks clean and good to me. Could you add a test case?
Contributor
Author
|
Thanks @comaniac |
d478d7d to
a51517c
Compare
a51517c to
a80115f
Compare
Contributor
|
Thanks @trevor-m |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…ication (apache#7977) * Remove ext params stored in metadata from params to avoid duplication * Add test for duplicate params
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…ication (apache#7977) * Remove ext params stored in metadata from params to avoid duplication * Add test for duplicate params
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…ication (apache#7977) * Remove ext params stored in metadata from params to avoid duplication * Add test for duplicate params
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…ication (apache#7977) * Remove ext params stored in metadata from params to avoid duplication * Add test for duplicate params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #7564
During compilation, weights from external modules are stored in the MetadataModule (.so), but they are still kept in params so they end up being duplicated.
This PR will remove from params only the weights which were stored in MetadataModule, solving the weight duplication issue.