[TVMC] --disable-pass option added to compile mode#7816
Merged
Conversation
d-smirnov
force-pushed
the
tvmc-disabled-pass
branch
2 times, most recently
from
2f04b63 to
5346303
Compare
comaniac
requested changes
Apr 9, 2021
comaniac
left a comment
comaniac
left a comment
Contributor
There was a problem hiding this comment.
Please also add test cases.
comaniac
added
status: need test case
Contributor
|
Also cc @leandron |
Added --disable-pass option to TVMC compile mode to disallow certain supplied passes in PassContext for the compiler. Change-Id: Iae1849d7b051ac9288509dc458a58788c865537a
d-smirnov
force-pushed
the
tvmc-disabled-pass
branch
from
5346303 to
d63f6b4
Compare
leandron
reviewed
Apr 9, 2021
leandron
left a comment
leandron
left a comment
Contributor
There was a problem hiding this comment.
Please add a some test cases.
Change-Id: If688f65441d3aa9967ab823adf899cfc704bd097
comaniac
added
status: accepted
and removed
status: need test case
Change-Id: I7a4706c03c0d64cade4977d431bcb25b3708f213
Change-Id: I33d6f6f86d182de2e21e895ec2dfe9f11f5916dd
leandron
approved these changes
Apr 13, 2021
leandron
left a comment
leandron
left a comment
Contributor
There was a problem hiding this comment.
Considering it is an advanced feature, and it is quite a big list of passes, I agree with your choice of showing it only when the user points to some pass that doesn't exist. LGTM.
Contributor
|
Thanks @d-smirnov @leandron |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [TVMC] --disable-pass option added to compile mode Added --disable-pass option to TVMC compile mode to disallow certain supplied passes in PassContext for the compiler. Change-Id: Iae1849d7b051ac9288509dc458a58788c865537a * Added test, addressed requests Change-Id: If688f65441d3aa9967ab823adf899cfc704bd097 * added printing of available passes Change-Id: I7a4706c03c0d64cade4977d431bcb25b3708f213 * C0415(import-outside-toplevel) Change-Id: I33d6f6f86d182de2e21e895ec2dfe9f11f5916dd
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [TVMC] --disable-pass option added to compile mode Added --disable-pass option to TVMC compile mode to disallow certain supplied passes in PassContext for the compiler. Change-Id: Iae1849d7b051ac9288509dc458a58788c865537a * Added test, addressed requests Change-Id: If688f65441d3aa9967ab823adf899cfc704bd097 * added printing of available passes Change-Id: I7a4706c03c0d64cade4977d431bcb25b3708f213 * C0415(import-outside-toplevel) Change-Id: I33d6f6f86d182de2e21e895ec2dfe9f11f5916dd
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [TVMC] --disable-pass option added to compile mode Added --disable-pass option to TVMC compile mode to disallow certain supplied passes in PassContext for the compiler. Change-Id: Iae1849d7b051ac9288509dc458a58788c865537a * Added test, addressed requests Change-Id: If688f65441d3aa9967ab823adf899cfc704bd097 * added printing of available passes Change-Id: I7a4706c03c0d64cade4977d431bcb25b3708f213 * C0415(import-outside-toplevel) Change-Id: I33d6f6f86d182de2e21e895ec2dfe9f11f5916dd
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* [TVMC] --disable-pass option added to compile mode Added --disable-pass option to TVMC compile mode to disallow certain supplied passes in PassContext for the compiler. Change-Id: Iae1849d7b051ac9288509dc458a58788c865537a * Added test, addressed requests Change-Id: If688f65441d3aa9967ab823adf899cfc704bd097 * added printing of available passes Change-Id: I7a4706c03c0d64cade4977d431bcb25b3708f213 * C0415(import-outside-toplevel) Change-Id: I33d6f6f86d182de2e21e895ec2dfe9f11f5916dd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added --disable-pass option to TVMC compile mode to disallow certain supplied passes in PassContext for the compiler.