Skip to content

[Relay][ONNX][Frontend] Fix issue when group attribute isnt defined in convtranspose.#7655

Merged
mbrookhart merged 1 commit into
apache:mainfrom
jwfromm:onnx_convtranspose_group
Mar 15, 2021
Merged

[Relay][ONNX][Frontend] Fix issue when group attribute isnt defined in convtranspose.#7655
mbrookhart merged 1 commit into
apache:mainfrom
jwfromm:onnx_convtranspose_group

Conversation

@jwfromm

@jwfromm jwfromm commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

The convtranspose importer incorrectly was assuming that the group attribute will always be defined. Instead, it is supposed to default to 1 when not provided. This 1-liner handles it properly. I also cleaned up some code duplication in the convtranspose test.

@jwfromm

jwfromm commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

@mbrookhart @masahi can one of you take a look at this small fix?

@mbrookhart mbrookhart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbrookhart mbrookhart merged commit 3beec22 into apache:main Mar 15, 2021
@mbrookhart

Copy link
Copy Markdown
Contributor

Thanks @jwfromm

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
@jwfromm jwfromm deleted the onnx_convtranspose_group branch April 12, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants