[Target] Add cuda tags and unit test#7410
Merged
Merged
Conversation
Member
Author
|
@junrushao1994 Please review, thanks! |
junrushao
requested changes
Feb 5, 2021
junrushao
left a comment
junrushao
left a comment
Member
There was a problem hiding this comment.
Overall it looks to me. Please see my only comment below. Let's get it in quickly after fixing the linter
junrushao
reviewed
Feb 5, 2021
junrushao
approved these changes
Feb 5, 2021
junrushao
left a comment
junrushao
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Thanks Xiyou for the first contribution 🎉
Member
|
@comaniac Would you mind taking a second look? |
Contributor
|
Thanks @zxybazh @junrushao1994 |
Member
|
Thanks @comaniac! For reference, we crawled the information from: [1] https://developer.nvidia.com/cuda-gpus |
junrushao
changed the title
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* Add cuda tags and unit test * Add missing space * Remove extra indent * Modify macro def position * Fix clang format * Fix clang format for set_config
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* Add cuda tags and unit test * Add missing space * Remove extra indent * Modify macro def position * Fix clang format * Fix clang format for set_config
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* Add cuda tags and unit test * Add missing space * Remove extra indent * Modify macro def position * Fix clang format * Fix clang format for set_config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit added cuda tags of most cuda devices for target specification and completed cuda target tag attributes.