Skip to content

[Relay][Training] fix grad for zeros and ones#7357

Merged
tmoreau89 merged 1 commit into
apache:mainfrom
altanh:ah/20210127-fix-zeros-ones-grad
Jan 29, 2021
Merged

[Relay][Training] fix grad for zeros and ones#7357
tmoreau89 merged 1 commit into
apache:mainfrom
altanh:ah/20210127-fix-zeros-ones-grad

Conversation

@altanh

@altanh altanh commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

The old gradient for these operators must have been written/updated before the dyn namespace was decided. I've updated the gradients to be correct now.

cc @mbrookhart @kevinthesun

@mbrookhart mbrookhart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmoreau89 tmoreau89 merged commit 4f414fd into apache:main Jan 29, 2021
@tmoreau89

Copy link
Copy Markdown
Contributor

Thank you @altanh and @mbrookhart the PR has been merged.

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 11, 2021
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants