[AutoScheduler] Update layout rewrite option setting for measuring#7156
Merged
Conversation
Member
Author
|
Will update the log version after #7144 since this PR has modified the log structure of SearchTask. |
jcf94
requested review from
comaniac and
merrymercy
and removed request for
merrymercy
comaniac
requested changes
Dec 23, 2020
| _ffi_api.AutoSchedule(search_policy, tuning_options) | ||
|
|
||
| def apply_best(self, log_file, layout_rewrite_option=None): | ||
| def apply_best(self, log_file, layout_rewrite_option=LayoutRewriteOption.NO_REWRITE): |
Contributor
There was a problem hiding this comment.
Out of scope: Is it possible to maintain the layout rewrite option in the record? This semantic indicates that you need to know the right layout rewrite option when you want to apply a tuned log.
Member
Author
There was a problem hiding this comment.
Emm ... Then we should also add this to maybe MeasureInput? I'm thinking this may not be so necessary, since we'll always try to apply layout rewrite on network, and this API may only be used in the replying of standalone ops. The user of this API should know what this means.
jcf94
commented
Dec 24, 2020
merrymercy
requested changes
Dec 24, 2020
merrymercy
reviewed
Dec 24, 2020
jcf94
force-pushed
the
update_layout_rewrite_option
branch
from
a80dec7 to
cee5dd0
Compare
comaniac
approved these changes
Dec 26, 2020
merrymercy
requested changes
Dec 26, 2020
Comment on lines
+1036
to
+1037
| new_attrs.Set("ori_placeholder_layout", tvm::String(origin_layout)); | ||
| new_attrs.Set("new_placeholder_layout", tvm::String(new_layout)); |
Member
Author
There was a problem hiding this comment.
I would need to get the layout information when exporting the kernel to run in an environment outside the tvm.
Emm... it's also fine to remove them here.
merrymercy
requested changes
Dec 26, 2020
merrymercy
approved these changes
Dec 26, 2020
tkonolige
pushed a commit
to tkonolige/incubator-tvm
that referenced
this pull request
Jan 11, 2021
…pache#7156) * Add layout rewrite options for measure * Update schedule for inserted transform stage * Set layout rewrite when tuning for network * Update the log version
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
…pache#7156) * Add layout rewrite options for measure * Update schedule for inserted transform stage * Set layout rewrite when tuning for network * Update the log version
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
…pache#7156) * Add layout rewrite options for measure * Update schedule for inserted transform stage * Set layout rewrite when tuning for network * Update the log version
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…pache#7156) * Add layout rewrite options for measure * Update schedule for inserted transform stage * Set layout rewrite when tuning for network * Update the log version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoScheduler uses a cost model to guide the search search.
We now have NO_REWRITE, INSERT_TRANSFORM_STAGE, REWRITE_FOR_PRE_TRANSFORMED three options when applying schedule from AutoScheduler.
In my tests, if we set REWRITE_FOR_PRE_TRANSFORMED in program measuring, the final schedule we get will trend to perform better in REWRITE_FOR_PRE_TRANSFORMED mode. Though this schedule also works in other options, it will not perform the best performance if we would like to get a kernel with NO_REWRITE.
This PR:
python/tvm/topi/x86/injective.py.cc @merrymercy @comaniac