Skip to content

Add a test for assymetric padding in ONNX conv and fix Importer to support it#6646

Merged
tmoreau89 merged 1 commit into
apache:masterfrom
mbrookhart:mbrookhart/onnx_assymetric_padding_conv
Oct 8, 2020
Merged

Add a test for assymetric padding in ONNX conv and fix Importer to support it#6646
tmoreau89 merged 1 commit into
apache:masterfrom
mbrookhart:mbrookhart/onnx_assymetric_padding_conv

Conversation

@mbrookhart

Copy link
Copy Markdown
Contributor

@tmoreau89 tmoreau89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, LGTM

@jwfromm jwfromm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent, thanks!

@tmoreau89 tmoreau89 merged commit 455d401 into apache:master Oct 8, 2020
@tmoreau89

Copy link
Copy Markdown
Contributor

Thanks @mbrookhart @jwfromm the PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants