[Relay] support i64 indices#6143
Conversation
|
@yzhliu @tqchen It's ready for review. I'm not sure if this pr introduces perf. regression (because some models may contain i64 indexing, and not all i64 can be narrowed). Do we need a compilation flag like |
|
Let us confirm the major networks and also notify the parties. We could have an option |
jwfromm
left a comment
There was a problem hiding this comment.
LGTM, excited for i64 support to finally make it in!
|
@hzfan FYI, I found that Keras MobileNetV2 model experiences a heavy perf regression with i64 indices enabled. This is on an AWS m5.12xlarge instance. |
Remove i32 casting at https://github.com/apache/incubator-tvm/blob/master/src/relay/backend/compile_engine.cc#L83