Skip to content

[Autotvm] Use VM compile to extract autotvm tasks#4328

Merged
zhiics merged 8 commits into
apache:masterfrom
icemelon:autotvm-relay
Jan 9, 2020
Merged

[Autotvm] Use VM compile to extract autotvm tasks#4328
zhiics merged 8 commits into
apache:masterfrom
icemelon:autotvm-relay

Conversation

@icemelon

@icemelon icemelon commented Nov 13, 2019

Copy link
Copy Markdown
Member

Current autotvm relay integration doesn't support extract autotvm tasks from a module.

@icemelon

icemelon commented Nov 13, 2019

Copy link
Copy Markdown
Member Author

@tmoreau89 @merrymercy Could you help review the pr?

@comaniac

comaniac commented Nov 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Did you measure the time to extract tasks using Relay VM?
The recent PR #4138 has optimized the task extraction time, so I am cauious if it would be faster or slower when using Relay VM.

@icemelon

icemelon commented Nov 13, 2019

Copy link
Copy Markdown
Member Author

Good point. I think it will slow down the task extraction time since it includes the codegen pass. I'll take a look and see if I can optimize it.

@icemelon

icemelon commented Jan 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@comaniac @zhiics @wweic @tqchen Updated the PR. Could you help review it?

@comaniac

comaniac commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

LGTM. Now the VM compilation has two steps, lower and codegen. Since we only need to run lower when extracting AutoTVM tasks, the extraction time should be much shorter.

zhiics
zhiics approved these changes Jan 8, 2020
View reviewed changes

@zhiics zhiics left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, it might be necessary to put some comments under compile to mention that the two different ways invoking lowering and codegen.

@icemelon

icemelon commented Jan 8, 2020

Copy link
Copy Markdown
Member Author

@zhiics Do you mean in the VMCompiler class?

@zhiics

zhiics commented Jan 8, 2020

Copy link
Copy Markdown
Member

@icemelon9 yes, my bad.

tmoreau89
tmoreau89 approved these changes Jan 8, 2020
View reviewed changes

@tmoreau89 tmoreau89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiics zhiics merged commit baae28b into apache:master Jan 9, 2020
@zhiics

zhiics commented Jan 9, 2020

Copy link
Copy Markdown
Member

Thanks @icemelon9 @comaniac @wweic @tmoreau89

@icemelon icemelon deleted the autotvm-relay branch January 9, 2020 01:16
@masahi masahi mentioned this pull request Jan 30, 2020
Closed
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
@icemelon @alexwong
[Autotvm] Use VM compile to extract autotvm tasks (apache#4328)
b573be1 
* [AutoTVM] Use vm compile in extracting task from relay

* update

* restructure vm compiler to reduce task extraction time

* x

* fix

* update doc

* udpate doc

* lint
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
@icemelon @alexwong
[Autotvm] Use VM compile to extract autotvm tasks (apache#4328)
d7319ad 
* [AutoTVM] Use vm compile in extracting task from relay

* update

* restructure vm compiler to reduce task extraction time

* x

* fix

* update doc

* udpate doc

* lint
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
@icemelon @zhiics
[Autotvm] Use VM compile to extract autotvm tasks (apache#4328)
59a6b39 
* [AutoTVM] Use vm compile in extracting task from relay

* update

* restructure vm compiler to reduce task extraction time

* x

* fix

* update doc

* udpate doc

* lint
@ZihengJiang ZihengJiang mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wweic wweic wweic approved these changes
@zhiics zhiics zhiics approved these changes
@tmoreau89 tmoreau89 tmoreau89 approved these changes

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@icemelon @comaniac @zhiics @wweic @tmoreau89