Skip to content

[Relay][TensorFlow] Remove 'input_0d_mismatch' special handling#3087

Merged
yzhliu merged 3 commits into
apache:masterfrom
lixiaoquan:tf_fe
Apr 26, 2019
Merged

[Relay][TensorFlow] Remove 'input_0d_mismatch' special handling#3087
yzhliu merged 3 commits into
apache:masterfrom
lixiaoquan:tf_fe

Conversation

@lixiaoquan

@lixiaoquan lixiaoquan commented Apr 24, 2019

Copy link
Copy Markdown
Contributor

@srkreddy1238 @alexeyr Please review

@alexeyr

alexeyr commented Apr 24, 2019

Copy link
Copy Markdown
Contributor

I won't be able to review before going on vacation, though it's good if Relay doesn't need it anymore. Maybe add some tests directly for tf.expand_dims to https://github.com/dmlc/tvm/blob/master/tests/python/frontend/tensorflow/test_forward.py? There don't seem to be any at the moment.

@lixiaoquan

Copy link
Copy Markdown
Contributor Author

Test is added

@yongwww yongwww left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

_test_forward_expand_dims(np.int32(1), 0)
_test_forward_expand_dims(np.array([1]), 0)
_test_forward_expand_dims(np.array([[1], [2]]), 0)
_test_forward_expand_dims(np.array([[1], [2]]), 1)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if "axis = -1" is supported here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's added

Comment thread python/tvm/relay/frontend/tensorflow.py

@srkreddy1238 srkreddy1238 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yzhliu yzhliu merged commit 036294c into apache:master Apr 26, 2019
@yzhliu

yzhliu commented Apr 26, 2019

Copy link
Copy Markdown
Member

Thanks @lixiaoquan @srkreddy1238 @yongwww

wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
…he#3087)

* [Relay][TensorFlow] Remove 'input_0d_mismatch' special handling

* Add more tests.

* Cover the case that strided_slice outputs a scalar
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
…he#3087)

* [Relay][TensorFlow] Remove 'input_0d_mismatch' special handling

* Add more tests.

* Cover the case that strided_slice outputs a scalar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants