[Tensorflow Frontend] Add saved model support and infer shape w/o add_shapes=True#2493
Conversation
yongwww
commented
Jan 23, 2019
yongwww
commented
- Add a wrapper "tensorflow_parser" to handle Tensorflow frozen single pb file, tensorflow saved model and checkpoints
- Infer shapes without "add_shapes=True", make the frontend more user friendly, much easier to support saved model
- Upstream from Amazon team, if possible we'd like to keep the commit history for our further investigation
TF parser: return the consistent error message to error handler
|
@srkreddy1238 @yzhliu @icemelon9 would be great if you guys help review it |
|
@yongwww thanks for saved bundle support. Will review it. |
Thanks, sure, will spend some time on that |
|
@srkreddy1238 Yes, we will spend work on Relay part as well, but probably in a different PR. @yongwww It looks that there are some lint problems. Please fix them first. |
yongwww
force-pushed
the
master
branch
2 times, most recently
from
4d0203d to
ae78620
Compare
|
@zhiics fixed lint issues, passed CI |
|
@srkreddy1238 incorporated your comments, pls help take a look at it again. Thanks! |
|
@srkreddy1238 Could you please take a look at this PR when you have some cycles? @yongwww has addressed your comments. Thank you. |
yzhliu
left a comment
yzhliu
left a comment
There was a problem hiding this comment.
@srkreddy1238 please review again, thanks.
|
@yongwww sorry about the delay I was occupied on some other task for some days. Will conclude this PR by Tomorrow. |
|
@srkreddy1238 resolved your comments, please take another look |
yzhliu
left a comment
yzhliu
left a comment
There was a problem hiding this comment.
@srkreddy1238 Could you help to review again?
srkreddy1238
left a comment
srkreddy1238
left a comment
There was a problem hiding this comment.
almost good to go, few changes.
Remove exception trail in tf parser error message Fix lint Fix comments
|
@srkreddy1238 could you pls take a another look? |
|
@yzhliu there was a request to keep commit history for this PR. |
|
Thanks @yongwww @srkreddy1238 I did rebase-merge per request, while it is not recommended as it prevents github attach related PR # for these commits, also individual commit might not be valid as @srkreddy1238 mentioned. Please avoid if possible. |
|
Squash merge is always the preferred approach. While it might prevent us from getting some of the precise contribution history, in general we do not count commits anyway so it is fine |
|
@tqchen @yzhliu @srkreddy1238 thanks all, guys! totally agree. I understand your concern, we will use squash merge the next time. My initial thought is keeping some history is helpful for us (aws) to upstream and downstream, anyway, we can handle it and avoid this case for sure. |
|
usually rebase will resolve most of the problem, regardless of which type of merging method |
5 participants
