[Tests][Refactor] Remove unused testing helpers#19800
Merged
Merged
Conversation
CompareBeforeAfter, skip_parameterizations, and xfail_parameterizations have
no remaining users anywhere in the repo. CompareBeforeAfter (a base class for
TIR before/after transform tests) has been superseded by the inline
assert_structural_equal(transform(Before), Expected) pattern, and the
{skip,xfail}_parameterizations helpers (which marked specific parametrizations
at runtime) are unused -- native pytest.param(..., marks=...) covers that need.
Also drop the private _mark_parameterizations helper they relied on and the
now-unused 'import textwrap'.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up python/tvm/testing/utils.py by removing the unused textwrap import, the helper functions _mark_parameterizations, xfail_parameterizations, and skip_parameterizations, and the CompareBeforeAfter utility class. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tqchen
approved these changes
Jun 16, 2026
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 16, 2026
CompareBeforeAfter, skip_parameterizations, and xfail_parameterizations
have no remaining users anywhere in the repo. CompareBeforeAfter (a base
class for TIR before/after transform tests) has been superseded by the
inline assert_structural_equal(transform(Before), Expected) pattern, and
the {skip,xfail}_parameterizations helpers (which marked specific
parametrizations at runtime) are unused -- native pytest.param(...,
marks=...) covers that need.
Also drop the private _mark_parameterizations helper they relied on and
the now-unused 'import textwrap'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompareBeforeAfter, skip_parameterizations, and xfail_parameterizations have no remaining users anywhere in the repo. CompareBeforeAfter (a base class for TIR before/after transform tests) has been superseded by the inline assert_structural_equal(transform(Before), Expected) pattern, and the {skip,xfail}_parameterizations helpers (which marked specific parametrizations at runtime) are unused -- native pytest.param(..., marks=...) covers that need.
Also drop the private _mark_parameterizations helper they relied on and the now-unused 'import textwrap'.