Skip to content

[Web] Destroy GPUDevice once on buffer creation error #19790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guan404ming merged 2 commits into from
Jun 16, 2026
Merged

[Web] Destroy GPUDevice once on buffer creation error #19790

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00a5da4
Destroy GPUDevice once on buffer creation error
guan404ming Jun 16, 2026
e8558c3
Update web/src/webgpu.ts
guan404ming Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions web/src/webgpu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,20 @@ function tryCreateBuffer(device: GPUDevice, descriptor: GPUBufferDescriptor) {

const buffer = device.createBuffer(descriptor);

device.popErrorScope().then((error) => {if (error) {device.destroy(); console.error(error);}});
device.popErrorScope().then((error) => {if (error) {device.destroy(); console.error(error);}});
device.popErrorScope().then((error) => {if (error) {device.destroy(); console.error(error);}});
// Destroy at most once even if multiple error types fire.
Promise.all([
device.popErrorScope(),
device.popErrorScope(),
device.popErrorScope(),
]).then((errors) => {
const captured = errors.filter((error): error is GPUError => error !== null);
if (captured.length > 0) {
device.destroy();
captured.forEach((error) => console.error(error));
}
}).catch((err) => {
console.error("Failed to pop error scopes:", err);
});
Comment thread
guan404ming marked this conversation as resolved.

return buffer;
}
Expand Down
Loading