[Hexagon][Tests] Clean up stale hexagon tests#19747
Merged
Merged
Conversation
The test_hexagon directory is not enrolled in CI and has drifted out of sync with the codebase: - Delete test_fixed_point_conversion.py: it imports tvm.topi.hexagon.utils, but the tvm.topi.hexagon module (including get_fixed_point_value under test) no longer exists in the source tree. - Delete test_2d_physical_buffers.py: its ir_module fixture was removed in apache#17665 (Feb 2025), leaving all 36 tests erroring at setup with "fixture 'ir_module' not found" ever since. - Fix test_take.py: drop the stale exec_mode="compiled" argument that tvm.compile no longer accepts. Both tests in the file pass again (llvm host target, no Hexagon hardware required).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes two test files, test_2d_physical_buffers.py and test_fixed_point_conversion.py, and updates tests/python/contrib/test_hexagon/test_take.py by removing the deprecated or unnecessary exec_mode="compiled" argument from the tvm.compile call. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
mshr-h
approved these changes
Jun 12, 2026
tqchen
approved these changes
Jun 12, 2026
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
The test_hexagon directory is not enrolled in CI and has drifted out of sync with the codebase: - Delete test_fixed_point_conversion.py: it imports tvm.topi.hexagon.utils, but the tvm.topi.hexagon module (including get_fixed_point_value under test) no longer exists in the source tree. - Delete test_2d_physical_buffers.py: its ir_module fixture was removed in apache#17665 (Feb 2025), leaving all 36 tests erroring at setup with "fixture 'ir_module' not found" ever since. - Fix test_take.py: drop the stale exec_mode="compiled" argument that tvm.compile no longer accepts. Both tests in the file pass again (llvm host target, no Hexagon hardware required). (cherry picked from commit 39cc48b)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
The test_hexagon directory is not enrolled in CI and has drifted out of sync with the codebase: - Delete test_fixed_point_conversion.py: it imports tvm.topi.hexagon.utils, but the tvm.topi.hexagon module (including get_fixed_point_value under test) no longer exists in the source tree. - Delete test_2d_physical_buffers.py: its ir_module fixture was removed in apache#17665 (Feb 2025), leaving all 36 tests erroring at setup with "fixture 'ir_module' not found" ever since. - Fix test_take.py: drop the stale exec_mode="compiled" argument that tvm.compile no longer accepts. Both tests in the file pass again (llvm host target, no Hexagon hardware required). (cherry picked from commit 39cc48b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test_hexagon directory is not enrolled in CI and has drifted out of sync with the codebase: