[Tests][LLVM] Gate stepvector intrinsic rename on LLVM 20#19745
Merged
Conversation
llvm.experimental.stepvector was renamed to llvm.stepvector in LLVM 20, not LLVM 18. On LLVM 18 and 19 the test picked the new name, which those versions do not know, failing call_llvm_intrin with "Unknown llvm intrinsic function llvm.stepvector". Use the new name only for LLVM >= 20.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the LLVM stepvector intrinsic name resolution in the scalable data type tests. Specifically, it changes the LLVM version threshold from 18 to 20 to align with LLVM 20's renaming of llvm.experimental.stepvector to llvm.stepvector. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
mshr-h
approved these changes
Jun 12, 2026
tqchen
approved these changes
Jun 12, 2026
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
llvm.experimental.stepvector was renamed to llvm.stepvector in LLVM 20, not LLVM 18. On LLVM 18 and 19 the test picked the new name, which those versions do not know, failing call_llvm_intrin with "Unknown llvm intrinsic function llvm.stepvector". Use the new name only for LLVM >= 20. (cherry picked from commit 2c46ff9)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
llvm.experimental.stepvector was renamed to llvm.stepvector in LLVM 20, not LLVM 18. On LLVM 18 and 19 the test picked the new name, which those versions do not know, failing call_llvm_intrin with "Unknown llvm intrinsic function llvm.stepvector". Use the new name only for LLVM >= 20. (cherry picked from commit 2c46ff9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llvm.experimental.stepvector was renamed to llvm.stepvector in LLVM 20, not LLVM 18. On LLVM 18 and 19 the test picked the new name, which those versions do not know, failing call_llvm_intrin with "Unknown llvm intrinsic function llvm.stepvector". Use the new name only for LLVM >= 20.