[CI] Run s_tir/transform tests in the python-unittest stage#19737
Merged
Conversation
The python-unittest stage enumerates test directories explicitly, and tests/python/s_tir/transform was never enrolled when the transform tests were migrated into the s_tir namespace (apache#18722). As a result the directory has not been exercised by CI at all, which let several regressions land on main unnoticed (since fixed in apache#19729 and apache#19735). Add the directory to TEST_FILES so the s_tir transform passes are covered. GPU-marked tests are filtered by the -m gpu marker selection in the gpuonly variant, so CPU enrollment is safe.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the "s_tir/transform" directory to the list of test files in the Python unit test script. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tqchen
approved these changes
Jun 11, 2026
tlopex
added a commit
to tlopex/tvm
that referenced
this pull request
Jun 12, 2026
test_cp_async_in_if_then_else compares the generated CUDA source byte-for-byte against a snapshot, and the cse_v* numbering in the generated source is currently nondeterministic across processes, so the snapshot comparison cannot be stable. Mark it xfail (non-strict) with a TODO so the s_tir/transform CI enrollment (apache#19737) is not blocked; the mark goes away once CSE ordering is made deterministic and the snapshot is regenerated (apache#19741).
tlopex
added a commit
to tlopex/tvm
that referenced
this pull request
Jun 12, 2026
test_cp_async_in_if_then_else compares the generated CUDA source byte-for-byte against a snapshot, and the cse_v* numbering in the generated source is currently nondeterministic across processes, so the snapshot comparison cannot be stable. Mark it xfail (non-strict) with a TODO so the s_tir/transform CI enrollment (apache#19737) is not blocked; the mark goes away once CSE ordering is made deterministic and the snapshot is regenerated (apache#19741).
spectrometerHBH
pushed a commit
that referenced
this pull request
Jun 12, 2026
This pr marks it xfail with a TODO so the s_tir/transform CI enrollment (#19737) is not blocked; the mark should be removed once the CSE determinism fix land.
Member
Author
|
@tvm-bot rerun |
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
) This pr marks it xfail with a TODO so the s_tir/transform CI enrollment (apache#19737) is not blocked; the mark should be removed once the CSE determinism fix land. (cherry picked from commit 6e6627e)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
…9737) The python-unittest stage enumerates test directories explicitly, and tests/python/s_tir/transform was never enrolled when the transform tests were migrated into the s_tir namespace (apache#18722). As a result the directory has not been exercised by CI at all, which let several regressions land on main unnoticed Add the directory to TEST_FILES so the s_tir transform passes are covered. GPU-marked tests are filtered by the -m gpu marker selection in the gpuonly variant, so CPU enrollment is safe. (cherry picked from commit 6f9609f)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
) This pr marks it xfail with a TODO so the s_tir/transform CI enrollment (apache#19737) is not blocked; the mark should be removed once the CSE determinism fix land. (cherry picked from commit 6e6627e)
MasterJH5574
pushed a commit
to MasterJH5574/tvm
that referenced
this pull request
Jun 15, 2026
…9737) The python-unittest stage enumerates test directories explicitly, and tests/python/s_tir/transform was never enrolled when the transform tests were migrated into the s_tir namespace (apache#18722). As a result the directory has not been exercised by CI at all, which let several regressions land on main unnoticed Add the directory to TEST_FILES so the s_tir transform passes are covered. GPU-marked tests are filtered by the -m gpu marker selection in the gpuonly variant, so CPU enrollment is safe. (cherry picked from commit 6f9609f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python-unittest stage enumerates test directories explicitly, and tests/python/s_tir/transform was never enrolled when the transform tests were migrated into the s_tir namespace (#18722). As a result the directory has not been exercised by CI at all, which let several regressions land on main unnoticed
Add the directory to TEST_FILES so the s_tir transform passes are covered. GPU-marked tests are filtered by the -m gpu marker selection in the gpuonly variant, so CPU enrollment is safe.