Skip to content

[CI] Fix release verification script#19700

Merged
tqchen merged 1 commit into
apache:mainfrom
MasterJH5574:tvm-dev/2026-06-09-release-check
Jun 10, 2026
Merged

[CI] Fix release verification script#19700
tqchen merged 1 commit into
apache:mainfrom
MasterJH5574:tvm-dev/2026-06-09-release-check

Conversation

@MasterJH5574

Copy link
Copy Markdown
Contributor

This commit fixes and updates the releaase verification script, including guarded binary scan and runtime deps installation.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release package test script test_release_package.sh by adding a step to install Python runtime dependencies, increasing compilation parallelism to -j16, and appending || true to the binary check command. The review feedback highlights several critical issues: first, using ${version} instead of ${version_rc} when finding files and changing directories will cause failures during release candidate verification under set -u. Second, referencing ${PYTHONPATH} directly under set -u will trigger an unbound variable error if it is not already set, which can be resolved using ${PYTHONPATH:-}. Third, hardcoding -j16 for compilation may lead to OOM or CPU starvation on resource-constrained environments, so dynamically scaling using nproc is suggested. Finally, replacing backticks with $(...) for command substitution is preferred for better readability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/scripts/release/test_release_package.sh
Comment thread tests/scripts/release/test_release_package.sh
Comment thread tests/scripts/release/test_release_package.sh Outdated
Comment thread tests/scripts/release/test_release_package.sh
This commit fixes and updates the releaase verification script,
including guarded binary scan and runtime deps installation.
@MasterJH5574 MasterJH5574 force-pushed the tvm-dev/2026-06-09-release-check branch from b577cdc to 660107d Compare June 9, 2026 19:32
@tqchen tqchen merged commit 9b5cd5d into apache:main Jun 10, 2026
9 checks passed
MasterJH5574 added a commit to MasterJH5574/tvm that referenced this pull request Jun 15, 2026
This commit fixes and updates the releaase verification script,
including guarded binary scan and runtime deps installation.

(cherry picked from commit 9b5cd5d)
MasterJH5574 added a commit to MasterJH5574/tvm that referenced this pull request Jun 15, 2026
This commit fixes and updates the releaase verification script,
including guarded binary scan and runtime deps installation.

(cherry picked from commit 9b5cd5d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants