[CI] Fix release verification script#19700
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the release package test script test_release_package.sh by adding a step to install Python runtime dependencies, increasing compilation parallelism to -j16, and appending || true to the binary check command. The review feedback highlights several critical issues: first, using ${version} instead of ${version_rc} when finding files and changing directories will cause failures during release candidate verification under set -u. Second, referencing ${PYTHONPATH} directly under set -u will trigger an unbound variable error if it is not already set, which can be resolved using ${PYTHONPATH:-}. Third, hardcoding -j16 for compilation may lead to OOM or CPU starvation on resource-constrained environments, so dynamically scaling using nproc is suggested. Finally, replacing backticks with $(...) for command substitution is preferred for better readability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This commit fixes and updates the releaase verification script, including guarded binary scan and runtime deps installation.
b577cdc to
660107d
Compare
This commit fixes and updates the releaase verification script, including guarded binary scan and runtime deps installation. (cherry picked from commit 9b5cd5d)
This commit fixes and updates the releaase verification script, including guarded binary scan and runtime deps installation. (cherry picked from commit 9b5cd5d)
This commit fixes and updates the releaase verification script, including guarded binary scan and runtime deps installation.