[REFACTOR][RUNTIME] Remove leftover microTVM/CRT crumbs#19622
Merged
Conversation
The [Refactor] Phase out microTVM commit (apache#17554) removed the bulk of microTVM, but a few crumbs were left behind: - src/runtime/meta_data.h: old snake_case header with a dmlc-based FunctionInfo struct. Replaced long ago by src/runtime/metadata.h (camelCase, ffi::ObjectRef-based). No file in the tree includes meta_data.h. - src/runtime/crt/common/crt_runtime_api.c: the sole remaining file in the src/runtime/crt/ subtree. Includes <tvm/runtime/c_runtime_api.h> and <tvm/runtime/crt/*> headers that no longer exist; not picked up by any RUNTIME_SRCS glob; uncompilable in the current tree. - cmake/utils/CRTConfig.cmake: defines generate_crt_config(), which has no callers and references a missing crt_config.h.template. - docs/conf.py: sphinx-gallery exclusion for a tutorial file (micro_mlperftiny.py) that no longer exists; simplified the regex. No code changes elsewhere — these are all isolated leaves.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes several files including a CRT configuration CMake script, a CRT runtime API C implementation, and the meta_data.h header file. Additionally, it updates docs/conf.py to match all files by changing the filename_pattern_default pattern to ".*". There are no review comments, so I have no further feedback to provide.
Member
Author
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/26526170281 Detailswith response |
spectrometerHBH
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The [Refactor] Phase out microTVM commit (#17554) removed the bulk of
microTVM, but a few crumbs were left behind. This PR removes all of
them:
src/runtime/meta_data.h: old snake_case header with a dmlc-basedFunctionInfostruct. Replaced long ago bysrc/runtime/metadata.h(camelCase,
ffi::ObjectRef-based). No file in the tree includesmeta_data.h.src/runtime/crt/common/crt_runtime_api.c: the sole remaining filein the
src/runtime/crt/subtree. Includes<tvm/runtime/crt/*>headers that no longer exist; not picked up by any
RUNTIME_SRCSglob; uncompilable in the current tree.
cmake/utils/CRTConfig.cmake: definesgenerate_crt_config(), whichhas no callers and references a missing
crt_config.h.template.docs/conf.py: sphinx-gallery exclusion for a tutorial file(
micro_mlperftiny.py) that no longer exists; simplified the regex.No code changes elsewhere — these are all isolated leaves with zero
callers or includers across
*.cc *.h *.c *.py *.cmake CMakeLists.txt.