[IR] Rename Call annotations to attrs#19618
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the tirx.Call expression by replacing the annotations field with attrs (of type Attrs) across both C++ and Python APIs. This change updates the AST nodes, serialization, printers, various transformations, and associated unit tests. The reviewer suggested updating the type annotation of attrs in the Python Call class to ir.Attrs | None to correctly handle cases where no attributes are provided and prevent static type checking issues.
tqchen
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
tirx::CallNode::annotationstoattrs, matching the existing RelaxCallNode::attrsconvention.Previously, TIRX Call metadata was stored in a
Map<String, Any>field namedannotations. This PR makes it a first-classAttrsfield instead, so call-level metadata follows the same representation and naming style as Relax calls.