[Relax][Frontend][TFLite] Add BROADCAST_TO, EMBEDDING_LOOKUP, and SELECT_V2#19489
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the tvm-ffi subproject and expands the TFLite frontend for Relax by implementing support for BROADCAST_TO, EMBEDDING_LOOKUP, and SELECT_V2 operators, accompanied by new test cases. Additionally, convert_gather was updated to use astype instead of cast. Feedback focuses on ensuring the shape argument in convert_broadcast_to is correctly converted to a ShapeExpr or integer list to avoid inference errors, and recommending an explicit int32 cast for indices in convert_embedding_lookup to improve backend compatibility.
Member
|
Could you resolve the conflict so that we can merge it in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for three new operators in the Relax TFLite frontend:
BROADCAST_TO,EMBEDDING_LOOKUP,andSELECT_V2.Passed all newly added unit tests using
reference #19412