[REFACTOR][S-TIR] Minimize src/support/ by relocating s_tir-private headers#19460
Merged
Conversation
…eaders
This PR consolidates src/support/ by moving s_tir-private helpers into
a new src/s_tir/support/ directory, merging generic_arena.h into arena.h,
extracting fp-limits constants into limits.h, and deleting unused code.
Main changes:
- Move table_printer.h, array.h (→ array_utils.h), nd_int_set.h, and
parallel_for.h (made header-only) to src/s_tir/support/
- Merge generic_arena.h content into arena.h; delete generic_arena.h
- Extract kMax* fp-limit constants from scalars.h into new limits.h;
delete scalars.{h,cc} (unused functions) and hexdump.h
- Rewrite layout_transformation.cc to use std::vector instead of std::list,
removing the support::AsList/AsArray dependency
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the support directory by moving several utilities, including parallel_for, array_utils, and nd_int_set, to src/s_tir/support/ and merging generic_arena.h into arena.h. It also removes scalars.h, scalars.cc, and hexdump.h, while introducing limits.h for numeric range constants. Review feedback identifies a typo in a static assertion message and highlights the need to relocate deleted unit tests for parallel_for to ensure continued test coverage.
The merge of generic_arena.h into arena.h carried a typo in the alignment check error message. Correct "To large" to "Too large".
Member
Author
|
Fixed the typo in the error message! Changed 'To large alignment' to 'Too large alignment' in commit 35fbe1f on this branch. |
tlopex
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocates s_tir-private headers from src/support/ into src/s_tir/support/, minimizing public API surface. Changes include:
Test plan: