[REFACTOR] Phase out unreachable contrib/rust_extension.cc#19458
Merged
spectrometerHBH merged 1 commit intoApr 27, 2026
Merged
Conversation
The file's body is wrapped in `#ifdef RUST_COMPILER_EXT` which is defined nowhere in the tree, making the contents unreachable. `cmake/modules/RustExt.cmake` was previously removed; the `USE_RUST_EXT` cmake option became orphan scaffolding. Remove the source file and the dead `USE_RUST_EXT` option.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the Rust extension support from the project by deleting the USE_RUST_EXT option from CMake configurations, removing the associated metadata from library info, and deleting the src/contrib/rust_extension.cc source file. I have no feedback to provide.
spectrometerHBH
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes
src/contrib/rust_extension.cc, a 32-line file whose entire body is wrapped in#ifdef RUST_COMPILER_EXT— a macro defined nowhere in the tree, making the file's contents unreachable in any build configuration. The orphanedUSE_RUST_EXTcmake option (no longer gates anything aftercmake/modules/RustExt.cmakewas previously removed) is also removed from CMakeLists.txt, LibInfo.cmake, and libinfo.cc.Test plan
cmake -G Ninja+ninja -j$(nproc)(no errors expected)libtvm.soandlibtvm_runtime.solink without unresolved referencestests/python/all-platform-minimal-test/(~75 tests, ~0.3s)pre-commit run --all-files