[Relax][FRONTEND][ONNX] Support Softmax, LogSoftmax and Hardmax when opset version ≤12#19428
Merged
Conversation
…max, LogSoftmax and Hardmax
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements legacy semantics for ONNX Softmax, LogSoftmax, and Hardmax operators (opset <= 12), which require flattening the input tensor into a 2D matrix based on the axis attribute. The review feedback correctly identifies that the current fallback logic for tensors with unknown static rank incorrectly defaults to modern (opset >= 13) behavior. It is recommended to raise a ValueError in these cases to prevent silent calculation errors for dynamic-rank tensors.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Commiters,
This PR is going to fix Softmax-family legacy semantics for opset<=12 and harden Hardmax fallback.
Summary: