[Relax][TFLite] Add NON_MAX_SUPPRESSION_V5 support#19349
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the NON_MAX_SUPPRESSION_V5 operator in the TFLite frontend for TVM Relax, replacing a previous placeholder with a functional implementation and adding comprehensive tests. The feedback highlights that the output tensors should be truncated to max_output_size to ensure shape consistency with TFLite's behavior. Additionally, it is recommended to use the actual number of input boxes as the upper bound for index clipping to improve memory safety, and to update the IR verification tests to assert the correct output shapes based on the maximum output size.
Aharrypotter
pushed a commit
to Aharrypotter/tvm
that referenced
this pull request
Apr 10, 2026
Partially resolves apache#18928 to run the tests: ```bash pytest tests/python/relax/test_frontend_tflite.py -v -k "nms" ``` <img width="728" height="44" alt="image" src="https://github.com/user-attachments/assets/fbd4092a-bc7f-459d-8d51-b0ef926b241f" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves #18928
to run the tests:
pytest tests/python/relax/test_frontend_tflite.py -v -k "nms"